From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Niklas Eklund Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/zuul 785d2d1619 2/6: Add defvar to zuul-log-mode-map Date: Tue, 30 Aug 2022 20:27:12 +0000 Message-ID: <87mtbl1nq7.fsf@posteo.net> References: <166188949022.4515.16575956645001384258@vcs2.savannah.gnu.org> <20220830195811.81C3BC00890@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25220"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 31 04:24:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTDOf-0006Nf-Sp for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Aug 2022 04:24:06 +0200 Original-Received: from localhost ([::1]:47416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTDOe-0004tY-7I for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 22:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT7pT-0007kN-GQ for emacs-devel@gnu.org; Tue, 30 Aug 2022 16:27:23 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:50845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT7pP-0005ad-Ma for emacs-devel@gnu.org; Tue, 30 Aug 2022 16:27:23 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 744A7240104 for ; Tue, 30 Aug 2022 22:27:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661891237; bh=0aKIZ49fLuyMuidj/xqXga/rdeETV1Ek60LLXS/TGs4=; h=From:To:Subject:Date:From; b=V03q+tDmkWdO0icRVRWSxdhIsbk9tilXbnVvgX+Z8GUp2baLwos9aTTNL+HgiED6t DZj5dhM3GxbQjfDu50hSZAwnYb1oLjTQ2Ez/23IGBebTDEdEpZsyubS/jPp+xQGhgs nnLyIPVRCsMTYi6H3G51reUcazZhqdINMw/HOCukUENBOGlMlTODnIgGJDlpA65njm OcxNrYjO34dafIaxHhSFOLa4dZTA00ordUOZibl7e6hdFhwXyD1jvvkSdE8FwCMckj DogCrex5038wqlvuRyKLCr0q7Wd4BEAfgOL1gTI5X/scjXJLgkAgpfPsWc3F449dfV L2TLRnh51oH6w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MHJkp13Nkz6tmb; Tue, 30 Aug 2022 22:27:13 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.66; envelope-from=niklas.eklund@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 30 Aug 2022 22:22:50 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294394 Archived-At: Stefan Monnier writes: > This `defvar` needs to come before the `define-derived-mode` otherwise > it'll do nothing. Fixed! > > Stfean > > > ELPA Syncer [2022-08-30 15:58:11] wrote: / Nilkas ;) >> branch: externals/zuul >> commit 785d2d1619245023695daa0a1951749b30c00f30 >> Author: Niklas Eklund >> Commit: Niklas Eklund >> >> Add defvar to zuul-log-mode-map >> --- >> zuul.el | 24 +++++++++++++----------- >> 1 file changed, 13 insertions(+), 11 deletions(-) >> >> diff --git a/zuul.el b/zuul.el >> index b7340dc61c..07f4916daf 100644 >> --- a/zuul.el >> +++ b/zuul.el >> @@ -1126,17 +1126,19 @@ Optionally provide extra parameters PARAMS, PARSER, METHOD, BUFFER or HEADERS." >> (font-lock-mode) >> (zuul--highlight-cmd)) >> >> -(let ((map zuul-log-mode-map)) >> - (define-key map (kbd "C-c C-b") #'zuul-switch-build) >> - (define-key map (kbd "C-c C-.") #'eldoc-mode) >> - (define-key map (kbd "C-c ]") #'zuul-next-build) >> - (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser) >> - (define-key map (kbd "C-c [") #'zuul-previous-build) >> - (define-key map (kbd "C-c C-p") #'zuul-previous-command) >> - (define-key map (kbd "C-c C-n") #'zuul-next-command) >> - (define-key map (kbd "C-c C-q") #'zuul-quit-build) >> - (define-key map (kbd "C-c C-s") #'zuul-switch-buildset) >> - (define-key map (kbd "C-c C-r") #'zuul-run-build-command)) >> +(defvar zuul-log-mode-map >> + (let ((map (make-sparse-keymap))) >> + (define-key map (kbd "C-c C-b") #'zuul-switch-build) >> + (define-key map (kbd "C-c C-.") #'eldoc-mode) >> + (define-key map (kbd "C-c ]") #'zuul-next-build) >> + (define-key map (kbd "C-c C-o") #'zuul-open-build-in-browser) >> + (define-key map (kbd "C-c [") #'zuul-previous-build) >> + (define-key map (kbd "C-c C-p") #'zuul-previous-command) >> + (define-key map (kbd "C-c C-n") #'zuul-next-command) >> + (define-key map (kbd "C-c C-q") #'zuul-quit-build) >> + (define-key map (kbd "C-c C-s") #'zuul-switch-buildset) >> + (define-key map (kbd "C-c C-r") #'zuul-run-build-command) >> + map)) >> >> (provide 'zuul) >>