From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] eglot-x.el: Protocol extensions for Eglot Date: Sat, 06 May 2023 15:14:52 +0200 Message-ID: <87lei1bnzn.fsf@betli.tmit.bme.hu> References: <874jorc7q2.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24194"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , emacs-devel@gnu.org To: Ruijie Yu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 06 15:15:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvHkt-00065F-N6 for ged-emacs-devel@m.gmane-mx.org; Sat, 06 May 2023 15:15:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvHkY-00083s-7k; Sat, 06 May 2023 09:14:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvHkW-00083i-Lr for emacs-devel@gnu.org; Sat, 06 May 2023 09:14:56 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvHkU-0003G7-Vc for emacs-devel@gnu.org; Sat, 06 May 2023 09:14:56 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3075e802738so2347527f8f.1 for ; Sat, 06 May 2023 06:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683378893; x=1685970893; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Hl0T5KQuQm1GOXSHFW+qQBRgMGWeoE4h+VGWBPDvR6Q=; b=SEphUFaCeVzZeGW3yHrL624PGgSt+Iug+q/sBQXHydRvVxAjEPd6rNPyS+REZbTTOM aGDef54rj9gqiJu0JOxE2oQ5agJFGKFeBJtiFVCyhGGSKKXqqbGr0Thr+vjfl9MZx+zq MvV7hLDhCW7G2noC5WFgmP4ht4mqhtlUz5ft9ZbP5CV2f+85pjOnl8e0gU+3n30gYePw FIPVUN7gE0h8M3wInscSTG4Z+OcpBkqJK+HeXGXx5WHVl3mlSjMLRo/W1ijjNL8kqjNK P7Q6uJrUcNzodt5oLFXO2C9pfOvuJdBmHjYR4OXWRI4ErVNnl0wrEYUIKxBBk+h7imQi gM6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683378893; x=1685970893; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Hl0T5KQuQm1GOXSHFW+qQBRgMGWeoE4h+VGWBPDvR6Q=; b=dABREDq08tiw+gBQcdGpFrc4aAeUZfigYTjyXmh540vlGpkr0rYSS7ups96mtotiqQ AawjFQFuauUKOQFRS6e5JDYXK+yLUQIoGBnLue0gdHBnW3oWjzXdW3rB7quQsaSO8/rn ZhCBprK1eYbNPrmjespHsC/2tw82CfHPPQG6NuieUu5d//t5MjlHo40t0qwE14ngAzU8 NgTsF88Sw7WQmcdnWs8TR5TcgaEvYx3LcpiOHx8ERh5CCPNma31gOjnPbCrgUqsqiZhO 3FpgX+ZmKj5mdZ03KkmE04ANnIYXB6AWQesBbJJzj13o0yNiWqfwdoL5GiopEdA6P/27 xuGg== X-Gm-Message-State: AC+VfDxWIkvm332GnwAJILwc9y7dSmPo9qe59b8HYcHrI+Y7L2speQmh W8sQJg6VgxsY3k/cZF8n3VEnun+wlitfTw== X-Google-Smtp-Source: ACHHUZ4m0T1cjX8fDTAyWXeRtGmOXj53vvpx3zBrNCWNTPqACMXctSpGTsTwORlNKc7evSVWbY5URg== X-Received: by 2002:a5d:4a91:0:b0:306:2e62:8d2e with SMTP id o17-20020a5d4a91000000b003062e628d2emr3187973wrq.1.1683378893141; Sat, 06 May 2023 06:14:53 -0700 (PDT) Original-Received: from betli.gmail.com (catv-89-134-210-182.catv.fixed.vodafone.hu. [89.134.210.182]) by smtp.gmail.com with ESMTPSA id c6-20020adfef46000000b003047dc162f7sm5347715wrp.67.2023.05.06.06.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 06:14:52 -0700 (PDT) In-Reply-To: (Ruijie Yu's message of "Fri, 05 May 2023 21:18:23 +0800") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=felician.nemeth@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305901 Archived-At: Thanks for your comments. I'll update the README based on this feedback. Ruijie Yu writes: > Didn't look into its sources, but the idea definitely sounds good. Some > in-line comments below regarding the commentary you attached. > > Felician Nemeth writes: > >> I'd like to submit a new package called eglot-x to ELPA. Its commentary >> starts with: >> >> ;; Eglot supports (a subset of) the Language Server Protocol. However, > > I think you should mention (as you did down below) that eglot only > supports standardized protocol features of the LSP, in particular, > _nothing more_ -- hence your package to support commonly-used, yet not > standardized protocol specs. Thoughts? > >> ;; there are useful protocol extensions that are not part of the >> ;; official protocol specification. Eglot-x adds support for some of >> ;; them. If you find a bug in Eglot, please, try to reproduce it > > New paragraph here at "if"? > >> ;; without Eglot-x, because Eglot-x is substantially modifies Eglot's > > Syntax: change "is substantially modifies" into either "substantially > modifies" or "has substantially modified". > >> ;; normal behavior as well. >> >> Jo=C3=A3o intend to support only the standardized protocol features in >> eglot.el, but lots of LSP servers extend the protocol in their own way. >> (It was Jo=C3=A3o who suggested the package name long ago.) I considered >> eglot-x just an experiment and a learning possibility, but people seem >> to use it, so I'd like to make their life easier by this submission. >> >> Currently, it mainly implements extensions for rust-analyzer and taplo, >> but some other extensions are supported as well. >> >> The package is hosted at https://github.com/nemethf/eglot-x >> >> Thanks, >> Felici=C3=A1n