unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 7c793c55cf 2/2: Improve 'ns-read-file-name' docstring
       [not found] ` <20220819140554.CA85DC008FE@vcs2.savannah.gnu.org>
@ 2022-08-20  2:03   ` Po Lu
  0 siblings, 0 replies; only message in thread
From: Po Lu @ 2022-08-20  2:03 UTC (permalink / raw)
  To: emacs-devel; +Cc: Robert Pluim

Robert Pluim <rpluim@gmail.com> writes:

>     Improve 'ns-read-file-name' docstring
>     
>     * src/nsfns.m (Fns_read_file_name): Use '-' instead of '_' when naming
>     args.
> ---
>  src/nsfns.m | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/nsfns.m b/src/nsfns.m
> index 1d3dcd3124..2699cf37a5 100644
> --- a/src/nsfns.m
> +++ b/src/nsfns.m
> @@ -1727,7 +1727,7 @@ Optional arg DIR, if non-nil, supplies a default directory.
>  Optional arg MUSTMATCH, if non-nil, means the returned file or
>  directory must exist.
>  Optional arg INIT, if non-nil, provides a default file name to use.
> -Optional arg DIR_ONLY_P, if non-nil, means choose only directories.  */)
> +Optional arg DIR-ONLY-P, if non-nil, means choose only directories.  */)
>    (Lisp_Object prompt, Lisp_Object dir, Lisp_Object mustmatch,
>     Lisp_Object init, Lisp_Object dir_only_p)
>  {

I guess in a few days I will delete this function and replace it with an
implementation of x-file-dialog in C, like the rest of the ports do.  I
think ns-read-file-name predates x-file-dialog, and the Lisp wrapper was
then halfheartedly placed on top shortly before the NS port was merged.



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-08-20  2:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <166091795409.16093.18205439177457042288@vcs2.savannah.gnu.org>
     [not found] ` <20220819140554.CA85DC008FE@vcs2.savannah.gnu.org>
2022-08-20  2:03   ` master 7c793c55cf 2/2: Improve 'ns-read-file-name' docstring Po Lu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).