From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Robert Pluim <rpluim@gmail.com>
Subject: Re: master 7c793c55cf 2/2: Improve 'ns-read-file-name' docstring
Date: Sat, 20 Aug 2022 10:03:03 +0800 [thread overview]
Message-ID: <87ilmnn02w.fsf@yahoo.com> (raw)
In-Reply-To: <20220819140554.CA85DC008FE@vcs2.savannah.gnu.org> (Robert Pluim's message of "Fri, 19 Aug 2022 10:05:54 -0400 (EDT)")
Robert Pluim <rpluim@gmail.com> writes:
> Improve 'ns-read-file-name' docstring
>
> * src/nsfns.m (Fns_read_file_name): Use '-' instead of '_' when naming
> args.
> ---
> src/nsfns.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/nsfns.m b/src/nsfns.m
> index 1d3dcd3124..2699cf37a5 100644
> --- a/src/nsfns.m
> +++ b/src/nsfns.m
> @@ -1727,7 +1727,7 @@ Optional arg DIR, if non-nil, supplies a default directory.
> Optional arg MUSTMATCH, if non-nil, means the returned file or
> directory must exist.
> Optional arg INIT, if non-nil, provides a default file name to use.
> -Optional arg DIR_ONLY_P, if non-nil, means choose only directories. */)
> +Optional arg DIR-ONLY-P, if non-nil, means choose only directories. */)
> (Lisp_Object prompt, Lisp_Object dir, Lisp_Object mustmatch,
> Lisp_Object init, Lisp_Object dir_only_p)
> {
I guess in a few days I will delete this function and replace it with an
implementation of x-file-dialog in C, like the rest of the ports do. I
think ns-read-file-name predates x-file-dialog, and the Lisp wrapper was
then halfheartedly placed on top shortly before the NS port was merged.
parent reply other threads:[~2022-08-20 2:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220819140554.CA85DC008FE@vcs2.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilmnn02w.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).