From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 7c793c55cf 2/2: Improve 'ns-read-file-name' docstring Date: Sat, 20 Aug 2022 10:03:03 +0800 Message-ID: <87ilmnn02w.fsf@yahoo.com> References: <166091795409.16093.18205439177457042288@vcs2.savannah.gnu.org> <20220819140554.CA85DC008FE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Robert Pluim To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 20 04:04:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oPDqD-0000mC-HN for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Aug 2022 04:04:02 +0200 Original-Received: from localhost ([::1]:38262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oPDqC-0007Sg-3C for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Aug 2022 22:04:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oPDpX-0006lx-MF for emacs-devel@gnu.org; Fri, 19 Aug 2022 22:03:19 -0400 Original-Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:42050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oPDpU-0003IF-9l for emacs-devel@gnu.org; Fri, 19 Aug 2022 22:03:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660960991; bh=KHfSaH6uu9EUvR+hNJTXsE+hyo8OxE8Noc1/Ni3k2+o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=j6ADKcngaU53iUCx7TEbJDWbGSj7Z4vS4ssWqumtoqbS7C0H73x537bEiNoBxyGPlWy1vnW7BF8RvmtI2A5A9UGf2SRFqLraIh8I0I8fn12Y2+06naQBC5dV4zI03GOFNm7HhFjp1rICz7rxYFx2XK8qWTwH+/qDWUwsS7O9pOGFg9riQdS9V42IpOiCo98hjBGpNQuK3xsB9gPxAgcC03hzhlnRq4+nV60NKcyMpnchkWPK6Zu+XxqVWlWKVIewkO3TyF5INyG0YWXqmovvtoP065vs7K5LWBOrfF6IH9jDelKKSGEhmMUevnBD0D9z1ArIZy2usboE9y/h3/o5Zg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1660960991; bh=WdtUU+Zi8fwwfAX3c0fyx9mGXtM5UMlfFSZSV8jGFqH=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Cu7ESkUQB7aBvUQHqrfFqxp7Ob9SssOFg2BIs74vrm81DAWz9xBbbhJPaRbBUjeu/xLWJcfU9scYBoPfhMurCN5IYaW/jt9ovouN3QAFXTrDGKTcbVa9uMtaZ1kbuBjZGCibZO8+j4Yyr/vKkGwW0STtDOx1PbWdBri3d+BGjWL6tNK3yNFk0ZWegNxLUFD24U7EN2LHj6wun6wamWBYCSAYDM91CWk6mgVWij8lH3JW2kTx3CbgadEiX1WOTGXFsnWxZRHuXJr34dLn9ufQMVAZ2te3G5FuqnT9AAkD/AT+NwEdE9CO0VJAyi0zhRo6UX8dQOO0sT8T4CkwVAiYUA== X-YMail-OSG: lV7icu4VM1nr2N7Uup.O5lXGUGg3kAW17qhz0vLSOK4sPSplYdJfZaH42KLNo4C dJ8wnFc6YbYFWJJHELFTgWBl.WhLs64p7oW5N_z2X5yZvBonXPfvSq3aFXLb0bK93ryI78xTUkdk 1XxRFKnk1tpbsNw3QSYsvbY11.5NwMS5rwUmbILrUU1nhCJAC9ymSwcnz_zVPlWE0BjZDyslkjQo ssUO._cu5rf0GDPC6jT7zqGbhqT7C0HFscTSDtYLzNpw4dAFIUKCFVEllVZ2qL8PeWPTloPLDlo0 BUL77JDTDpTndUBj4p5bEE03AGVgAL3X6MedbDOWbxusq4heVcDp6L5gINZiaF0Tnb5upepHQLdS zIKgYcz943hOVDqxLQ1z7HDt5_jMRSDVovzHTkQo5ORDizRLfUFR8zkVW36FCM0OQbMn2Y4ZBmBw ZENGbQKWltQGSiq2NE92yrpr7c3vYsSxP4FFbNBdflCjvEHPgl7H14yCmFUko1ycD_RdDdXVzznr etmveHkXXCmrwuKG3BGcmGJ4lzf2dH0vZRhMapViPQOUVze1hXuFiGNVsmcUWq3O5isXZ3fy_Apo sTrl7gPZ98XdcysWTmV8B.cuofnIaz78gnNdzI_SPpTn71c_fK.wmSlE8PLIgvymNyvynhurqPh3 nQ0wjX.7FaP148huO6bRNu4gngGkzknv4kmgkgDoXibi1uGT4LFPYfmMCL51xpAvBMPPFXaycYON zH0kIrj7fWkPnzcyFGF.VscdZPa_3Od_6i4cAUBW1myag3TvX_s6ibA5.dBKkGhtXG01H7BdL6da 0wTg_Je.OmJ.Gi62j_.NDiCg_DPNctK35B.LtysJ_K X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 20 Aug 2022 02:03:11 +0000 Original-Received: by hermes--canary-production-sg3-6f58cd9b5-p4pb6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9ef55e66232d153f4836b5200f620257; Sat, 20 Aug 2022 02:03:07 +0000 (UTC) In-Reply-To: <20220819140554.CA85DC008FE@vcs2.savannah.gnu.org> (Robert Pluim's message of "Fri, 19 Aug 2022 10:05:54 -0400 (EDT)") X-Mailer: WebService/1.1.20560 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.84; envelope-from=luangruo@yahoo.com; helo=sonic306-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293656 Archived-At: Robert Pluim writes: > Improve 'ns-read-file-name' docstring > > * src/nsfns.m (Fns_read_file_name): Use '-' instead of '_' when naming > args. > --- > src/nsfns.m | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/nsfns.m b/src/nsfns.m > index 1d3dcd3124..2699cf37a5 100644 > --- a/src/nsfns.m > +++ b/src/nsfns.m > @@ -1727,7 +1727,7 @@ Optional arg DIR, if non-nil, supplies a default directory. > Optional arg MUSTMATCH, if non-nil, means the returned file or > directory must exist. > Optional arg INIT, if non-nil, provides a default file name to use. > -Optional arg DIR_ONLY_P, if non-nil, means choose only directories. */) > +Optional arg DIR-ONLY-P, if non-nil, means choose only directories. */) > (Lisp_Object prompt, Lisp_Object dir, Lisp_Object mustmatch, > Lisp_Object init, Lisp_Object dir_only_p) > { I guess in a few days I will delete this function and replace it with an implementation of x-file-dialog in C, like the rest of the ports do. I think ns-read-file-name predates x-file-dialog, and the Lisp wrapper was then halfheartedly placed on top shortly before the NS port was merged.