unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Should diff.elisp.xfuncname match cl-lib macros?
Date: Sat, 16 Mar 2019 21:54:55 +0000	[thread overview]
Message-ID: <87ftrmeb80.fsf@tcd.ie> (raw)
In-Reply-To: <83imwiydnr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Mar 2019 18:42:00 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Sat, 16 Mar 2019 15:30:22 +0000
>> Cc: emacs-devel@gnu.org
>> 
>> >> Given the increasing presence of cl-defuns, cl-defgenerics, etc. in the
>> >> emacs.git sources, would it be welcome to additionally match cl-lib
>> >> macros?
>> >
>> > Yes, please,
>> 
>> I can think of three ways to achieve this given the lack of shy groups
>> in EREs:
>
> Is this feature even useful with Lisp?  I find it mostly useless,
> here's a typical example:
>
>   git log -L :next-line:lisp/simple.el
>
> Type this command in your repository, then watch the fun.  More fun is
> available when Git for some reason decides you asked about some
> variable, not a function (and in Lisp we frequently have variables by
> the same name as a function).

I don't think Git ever tries to distinguish between variables and
functions, despite the name of xfuncname.

> So I think until we fix this basic deficiency, extending that to more
> symbols will just add to the mess.  YMMV.

Which deficiency do you mean?  That 'git log -L' picks up
next-line-or-history-element instead of next-line in your example,
i.e. that it's currently inaccurate?  How do you usually use this
feature?  What kind of fix do you envision?  (Sorry, I don't have
experience using this Git feature.)

-- 
Basil



  parent reply	other threads:[~2019-03-16 21:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 16:42 Should diff.elisp.xfuncname match cl-lib macros? Basil L. Contovounesios
2019-03-15 18:21 ` Stefan Monnier
2019-03-16  3:56   ` Richard Stallman
2019-03-16 15:33     ` cl-defun vs defun (was: Should diff.elisp.xfuncname match cl-lib macros?) Basil L. Contovounesios
2019-03-17  2:41       ` Richard Stallman
2019-03-16 15:30   ` Should diff.elisp.xfuncname match cl-lib macros? Basil L. Contovounesios
2019-03-16 16:42     ` Eli Zaretskii
2019-03-16 17:12       ` Stefan Monnier
2019-03-16 17:33         ` Eli Zaretskii
2019-03-16 18:14           ` Stefan Monnier
2019-03-16 21:55             ` Basil L. Contovounesios
2019-03-16 21:54       ` Basil L. Contovounesios [this message]
2019-03-17  3:37         ` Eli Zaretskii
2019-03-17  8:14           ` Andreas Schwab
2019-03-17 15:22           ` Basil L. Contovounesios
2019-03-17 21:33       ` Juri Linkov
2019-03-18  1:14         ` Stefan Monnier
2019-03-18 21:02           ` Juri Linkov
2019-05-13  1:40         ` Basil L. Contovounesios
2019-05-20 15:03           ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftrmeb80.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).