unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>,
	Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: Should diff.elisp.xfuncname match cl-lib macros?
Date: Mon, 18 Mar 2019 23:02:36 +0200	[thread overview]
Message-ID: <87imwg3q8z.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwv7ecx0yui.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 17 Mar 2019 21:14:20 -0400")

>> Maybe this feature could be used by ‘C-x v h’ (vc-region-history)
>> in case when there is no active region.  Currently it signals
>> an error "The mark is not active now", but could use the name
>> of the current defun for '-L :defun:filename'.
>
> Wouldn't mark-defun give a better result (i.e. let the major mode
> determine the corresponding region rather than rely on Git's xfuncname)?

I can confirm that 'C-M-h C-x v h' produces the same result as
'-L :funcname:filename' for most cases, and is more reliable
for ambiguous names like 'next-line'.



  reply	other threads:[~2019-03-18 21:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 16:42 Should diff.elisp.xfuncname match cl-lib macros? Basil L. Contovounesios
2019-03-15 18:21 ` Stefan Monnier
2019-03-16  3:56   ` Richard Stallman
2019-03-16 15:33     ` cl-defun vs defun (was: Should diff.elisp.xfuncname match cl-lib macros?) Basil L. Contovounesios
2019-03-17  2:41       ` Richard Stallman
2019-03-16 15:30   ` Should diff.elisp.xfuncname match cl-lib macros? Basil L. Contovounesios
2019-03-16 16:42     ` Eli Zaretskii
2019-03-16 17:12       ` Stefan Monnier
2019-03-16 17:33         ` Eli Zaretskii
2019-03-16 18:14           ` Stefan Monnier
2019-03-16 21:55             ` Basil L. Contovounesios
2019-03-16 21:54       ` Basil L. Contovounesios
2019-03-17  3:37         ` Eli Zaretskii
2019-03-17  8:14           ` Andreas Schwab
2019-03-17 15:22           ` Basil L. Contovounesios
2019-03-17 21:33       ` Juri Linkov
2019-03-18  1:14         ` Stefan Monnier
2019-03-18 21:02           ` Juri Linkov [this message]
2019-05-13  1:40         ` Basil L. Contovounesios
2019-05-20 15:03           ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imwg3q8z.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=contovob@tcd.ie \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).