unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Should diff.elisp.xfuncname match cl-lib macros?
Date: Sat, 16 Mar 2019 21:55:15 +0000	[thread overview]
Message-ID: <87ef76eb7g.fsf@tcd.ie> (raw)
In-Reply-To: <jwv36nm7ks6.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 16 Mar 2019 14:14:17 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> AFAIK xfuncname is mostly used to add the "containing function name"
>>> on the header of each diff hunk.
>> That's a million times less important to me than "git log -L".
>
> Indeed, it's not an important feature at all.  It's just a nice "frill".
>
> Given the inevitable unreliability of the info it gets, I'm surprised it
> grew to take a more significant role in -L.  I guess it's still
> worthwhile in the sense that it's good when it works and when it doesn't
> you're no worse off than if you didn't have that feature.

I agree, FWIW.  My main use for xfuncname is as a manual alternative to
add-change-log-entry, by using diff hunk headers to know where a change
has been made.  When searching Git logs I tend to use --grep or -G
rather than -L.

-- 
Basil



  reply	other threads:[~2019-03-16 21:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 16:42 Should diff.elisp.xfuncname match cl-lib macros? Basil L. Contovounesios
2019-03-15 18:21 ` Stefan Monnier
2019-03-16  3:56   ` Richard Stallman
2019-03-16 15:33     ` cl-defun vs defun (was: Should diff.elisp.xfuncname match cl-lib macros?) Basil L. Contovounesios
2019-03-17  2:41       ` Richard Stallman
2019-03-16 15:30   ` Should diff.elisp.xfuncname match cl-lib macros? Basil L. Contovounesios
2019-03-16 16:42     ` Eli Zaretskii
2019-03-16 17:12       ` Stefan Monnier
2019-03-16 17:33         ` Eli Zaretskii
2019-03-16 18:14           ` Stefan Monnier
2019-03-16 21:55             ` Basil L. Contovounesios [this message]
2019-03-16 21:54       ` Basil L. Contovounesios
2019-03-17  3:37         ` Eli Zaretskii
2019-03-17  8:14           ` Andreas Schwab
2019-03-17 15:22           ` Basil L. Contovounesios
2019-03-17 21:33       ` Juri Linkov
2019-03-18  1:14         ` Stefan Monnier
2019-03-18 21:02           ` Juri Linkov
2019-05-13  1:40         ` Basil L. Contovounesios
2019-05-20 15:03           ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef76eb7g.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).