From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Should diff.elisp.xfuncname match cl-lib macros? Date: Sat, 16 Mar 2019 21:54:55 +0000 Message-ID: <87ftrmeb80.fsf@tcd.ie> References: <87wol0qecg.fsf@tcd.ie> <87a7hug7ld.fsf@tcd.ie> <83imwiydnr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223347"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 22:55:11 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5HGp-000w14-3D for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 22:55:11 +0100 Original-Received: from localhost ([127.0.0.1]:46825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HGn-0004RV-W6 for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 17:55:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HGg-0004RO-Mu for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:55:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5HGf-0000Ao-DJ for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:55:02 -0400 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:42244) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5HGe-0008UM-On for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:55:01 -0400 Original-Received: by mail-ed1-x52e.google.com with SMTP id j89so10472029edb.9 for ; Sat, 16 Mar 2019 14:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dnBKE7aY2CXog+gPbiJgNxGpubN0XrAmSXnUjKcke1w=; b=oSMCMRfL8PkeBCANHQlMQXULVHFC1pGVDIjVKCJ2dLc5QJlUdLWORuSaxuu5WdtxfU eswzQRRphYeGfoSzpa3dNZpdVRAlafqCKHvcBzLgK3PPAKXbzzTzZlk12DGv3Qa8B9ZT 3S2eH7FWWJhJ3RQ0IONNn0bQ3Lo7NgvlvEUyGmqiIyhM6YNr7Kyx2AVsoTIRb5BJWXk5 m+ho+f+AODRsZjtmB9eCE7haPsA+GEFQ5KybVFVXdZIyl5HEEOeUY5FYFxr1YOE48L7D qkN2ifIHhLkcZWpt/6RX6AXXQkZZy/M40X7ImKy9lgdZvmoBzFfSyu90vGBZe4bZC61w vJIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dnBKE7aY2CXog+gPbiJgNxGpubN0XrAmSXnUjKcke1w=; b=kXLBL0mZlX3n0+WVgG9sQ4i13VS0QXL2pvfrv5XgpB6BRtqZFZ6Oig/LCZ16KNQXkO 2LBV0ee3Q4HoRcspliigfeA3xg/HzJCJBhqx95F/NalwIzE8IwXNf2JvGIJsPon91nU0 GtYxJwRajtLBHdZ1ZpqfKFStsIPM8bg8IribdmNPGE/I3SQrGt6al1RTNbV074+VHbOI VFVJq9kF2VjvOt/JwllQXK2iD0i4tWeSBrOL9ijrKkWrzJdCj9vfOBmn3L1rM7UDZ2hi c1gzyl6osbKabeEK26QApb7cRbTfRutPt8w+23tVm+qkXH7EdcMb3vchRT/3oEeo0YNG YrQQ== X-Gm-Message-State: APjAAAWvpyM38at/zLDpl0ZEJZWiswMbLRtYOPURwtZeihnOCUXuNZAd AgXgjLPEeEtmqiXCUq9QoJRWqA== X-Google-Smtp-Source: APXvYqxJqnkt9Rl4WRYUCZdTAcLXH2i0RULTl/ywSWXoQveV0Eue/G3E/jQP8HUvCgrEULq5ikn/Eg== X-Received: by 2002:a17:906:a85a:: with SMTP id dx26mr3303461ejb.206.1552773297788; Sat, 16 Mar 2019 14:54:57 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id x4sm1613237eds.63.2019.03.16.14.54.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 16 Mar 2019 14:54:56 -0700 (PDT) In-Reply-To: <83imwiydnr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Mar 2019 18:42:00 +0200") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234245 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Date: Sat, 16 Mar 2019 15:30:22 +0000 >> Cc: emacs-devel@gnu.org >> >> >> Given the increasing presence of cl-defuns, cl-defgenerics, etc. in the >> >> emacs.git sources, would it be welcome to additionally match cl-lib >> >> macros? >> > >> > Yes, please, >> >> I can think of three ways to achieve this given the lack of shy groups >> in EREs: > > Is this feature even useful with Lisp? I find it mostly useless, > here's a typical example: > > git log -L :next-line:lisp/simple.el > > Type this command in your repository, then watch the fun. More fun is > available when Git for some reason decides you asked about some > variable, not a function (and in Lisp we frequently have variables by > the same name as a function). I don't think Git ever tries to distinguish between variables and functions, despite the name of xfuncname. > So I think until we fix this basic deficiency, extending that to more > symbols will just add to the mess. YMMV. Which deficiency do you mean? That 'git log -L' picks up next-line-or-history-element instead of next-line in your example, i.e. that it's currently inaccurate? How do you usually use this feature? What kind of fix do you envision? (Sorry, I don't have experience using this Git feature.) -- Basil