From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Should diff.elisp.xfuncname match cl-lib macros? Date: Sat, 16 Mar 2019 21:55:15 +0000 Message-ID: <87ef76eb7g.fsf@tcd.ie> References: <87wol0qecg.fsf@tcd.ie> <87a7hug7ld.fsf@tcd.ie> <83imwiydnr.fsf@gnu.org> <83h8c2ybaa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="224945"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 22:55:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5HHA-000wNd-5a for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 22:55:32 +0100 Original-Received: from localhost ([127.0.0.1]:46851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HH9-0004eq-5p for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 17:55:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5HGx-0004da-4Y for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:55:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5HGw-0001F8-BW for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:55:19 -0400 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:38191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5HGw-00018Y-0F for emacs-devel@gnu.org; Sat, 16 Mar 2019 17:55:18 -0400 Original-Received: by mail-ed1-x52f.google.com with SMTP id e10so6578515edy.5 for ; Sat, 16 Mar 2019 14:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=s86u9Xl1pX+h/isRHmj+vPvQzf80IuAm/R6V8HE6yfA=; b=wYTQRcWgw9zr+OHH2ry364H5w5WHkIVKYqp7jgs6B0tT8jzVpz15slZGEidnePSxZm oPbqVjLYuTSy94A6SCd7R898+aQNBlQqTUig3GW+IMRv5bSn0Erqc9hsPBCMd20qctMc +ed+nLEobaq9OrwAAXAb13i2j6Gv0OBU7KxjIRAvZfcTVtzyN1ojKb6k73nhMt6GFgkT MHxR/Ggk7hJ7mRmDIBzqzuFPk6HeyXOw9uAA7+o0GYA7JsCBiZ/Wt/3/M1cp5J3eF8LX 3TjeJOVfs1PwuAyAaNRRHbOz7rz9Ap68Lp6PHO6UgkXyIsYQ1vCyKHSdHgy92xCq/r16 ji0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=s86u9Xl1pX+h/isRHmj+vPvQzf80IuAm/R6V8HE6yfA=; b=hsqB7jDjPsrl80uysBYRBhjx8vcsg8opGPSxg2BGbX4ONN+CrPduNuifb2QAtphKV9 gELVx5QzQZq/hb8gBZNbE/fzMeL0KTP45jRehUp5RBPdrj5BPFFOlbMRcespnzO/Sj6g pjngeMqqehz3naP4WF5z91TrQmhM+L8XPxd0ewAkuLuePjPMG7UsRjW1x4FoxPHiS/xJ /fpz0CPDHiyFBrXFZPAgUaDIYZoj6P+aypWrMFsmit0DCrwrAkFk8ZIaXWSkazyEllIc XEHaK49McC19wVvdEpazhzK/WKWDXqnasPmkX7XZ9Z5aICUMMj4VaOeIhwKWlMrIwhk9 sb4w== X-Gm-Message-State: APjAAAVy8fZmSUCi7v5IWeflpM22t3N9fo1H3oMrzq1vAxrTPSTG3QY4 sX8xsrHjb5+KcSY7ff+vR+1gfJUrPlM= X-Google-Smtp-Source: APXvYqyhvFoDMly2m8yoai+nd5D0N2dLFPjBdfhZPimZ5v44C8hEjgxP06/5UvmwFVpUF++0bkoFlg== X-Received: by 2002:a50:a54b:: with SMTP id z11mr1844513edb.133.1552773316911; Sat, 16 Mar 2019 14:55:16 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id d10sm1954643edk.14.2019.03.16.14.55.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 16 Mar 2019 14:55:16 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sat, 16 Mar 2019 14:14:17 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234246 Archived-At: Stefan Monnier writes: >>> AFAIK xfuncname is mostly used to add the "containing function name" >>> on the header of each diff hunk. >> That's a million times less important to me than "git log -L". > > Indeed, it's not an important feature at all. It's just a nice "frill". > > Given the inevitable unreliability of the info it gets, I'm surprised it > grew to take a more significant role in -L. I guess it's still > worthwhile in the sense that it's good when it works and when it doesn't > you're no worse off than if you didn't have that feature. I agree, FWIW. My main use for xfuncname is as a manual alternative to add-change-log-entry, by using diff hunk headers to know where a change has been made. When searching Git logs I tend to use --grep or -G rather than -L. -- Basil