unofficial mirror of 
 help / color / mirror / code / Atom feed
From: "James N. V. Cash" <>
Subject: [PATCH] avoid hard-coded assumptions in image scaling
Date: Sun, 02 May 2021 16:18:30 -0400	[thread overview]
Message-ID: <> (raw)

In image-compute-scaling-factor in images.el, it currently hard-codes
the assumption that the average character width is 10 pixels. Since
`frame-char-width` gives this information though, it seems like it's less
error-prone to use that function instead of assuming.

 lisp/image.el | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/lisp/image.el b/lisp/image.el
index 610d020aab..8a9cfec841 100644
--- a/lisp/image.el
+++ b/lisp/image.el
@@ -561,12 +561,11 @@ image-compute-scaling-factor
    ((numberp scaling) scaling)
    ((eq scaling 'auto)
     (let ((width (/ (float (window-width nil t)) (window-width))))
-      ;; If we assume that a typical character is 10 pixels in width,
-      ;; then we should scale all images according to how wide they
-      ;; are.  But don't scale images down.
-      (if (< width 10)
+      ;; We should scale all images according to how wide they are.
+      ;; But don't scale images down.
+      (if (< width (frame-char-width))
-        (/ (float width) 10))))
+        (/ (float width) (frame-char-width)))))
     (error "Invalid scaling factor %s" scaling))))


             reply	other threads:[~2021-05-02 20:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02 20:18 James N. V. Cash [this message]
2021-05-02 20:51 ` Lars Ingebrigtsen
2021-05-02 20:56   ` James N. V. Cash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \
    --subject='Re: [PATCH] avoid hard-coded assumptions in image scaling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).