unofficial mirror of 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <>
To: "James N. V. Cash" <>
Subject: Re: [PATCH] avoid hard-coded assumptions in image scaling
Date: Sun, 02 May 2021 22:51:49 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (James N. V. Cash's message of "Sun, 02 May 2021 16:18:30 -0400")

"James N. V. Cash" <> writes:

> In image-compute-scaling-factor in images.el, it currently hard-codes
> the assumption that the average character width is 10 pixels. Since
> `frame-char-width` gives this information though, it seems like it's less
> error-prone to use that function instead of assuming.


> +      ;; We should scale all images according to how wide they are.
> +      ;; But don't scale images down.
> +      (if (< width (frame-char-width))
>            1
> -        (/ (float width) 10))))
> +        (/ (float width) (frame-char-width)))))

The point of the heuristic here is that we want to scale images up on
HiDPI screens, so the current code gives me a scaling factor of 2.3.
(I've got a 14" 4K screen.)

=> 23

With your patch, it'll return 1, of course, which is exactly the
opposite of what we want.

(The function could just have used (frame-char-width) divided by ten, I
guess, instead of computing it itself.)

(domestic pets only, the antidote for overdose, milk.)
   bloggy blog:

  reply	other threads:[~2021-05-02 20:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02 20:18 James N. V. Cash
2021-05-02 20:51 ` Lars Ingebrigtsen [this message]
2021-05-02 20:56   ` James N. V. Cash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] avoid hard-coded assumptions in image scaling' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).