message.el and mml-secure-bcc-is-safe

message.el and mml-secure-bcc-is-safe

[Yuri D'Elia]

I'd like to manipulate the mml tags on the message inside the
'message-send-hook depending on the recipient.

By reading though message.el, this seems to be possible as the hook is
ran early enough.

However, I notice that (mml-secure-bcc-is-safe) is called before the
hook. If I plan to modify the tags, it actually makes sense to run it
just afterwards instead so that it checks the final headers and tags.

Could we move (mml-secure-bcc-is-safe) just after the hook?
It makes more sense to me, unless there's some specific reason to do so.

Re: message.el and mml-secure-bcc-is-safe

[Lars Ingebrigtsen]

Yuri D'Elia <wavexx@thregr.org> writes:

> I'd like to manipulate the mml tags on the message inside the
> 'message-send-hook depending on the recipient.
>
> By reading though message.el, this seems to be possible as the hook is
> ran early enough.
>
> However, I notice that (mml-secure-bcc-is-safe) is called before the
> hook. If I plan to modify the tags, it actually makes sense to run it
> just afterwards instead so that it checks the final headers and tags.
>
> Could we move (mml-secure-bcc-is-safe) just after the hook?
> It makes more sense to me, unless there's some specific reason to do so.

I'm not sure...  there might be subtleties there...  I've added Jens to
the Cc; he added the code so he might have an opinion.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: message.el and mml-secure-bcc-is-safe

[Jens Lechtenboerger]

On 2017-01-21, at 17:34, Lars Ingebrigtsen wrote:

> Yuri D'Elia <wavexx@thregr.org> writes:
>
>> I'd like to manipulate the mml tags on the message inside the
>> 'message-send-hook depending on the recipient.
>>
>> By reading though message.el, this seems to be possible as the hook is
>> ran early enough.
>>
>> However, I notice that (mml-secure-bcc-is-safe) is called before the
>> hook. If I plan to modify the tags, it actually makes sense to run it
>> just afterwards instead so that it checks the final headers and tags.
>>
>> Could we move (mml-secure-bcc-is-safe) just after the hook?
>> It makes more sense to me, unless there's some specific reason to do so.
>
> I'm not sure...  there might be subtleties there...  I've added Jens to
> the Cc; he added the code so he might have an opinion.

There was no particular reason for adding the bcc-check before
executing that hook.  Feel free to exchange their order.

Best wishes
Jens

Re: message.el and mml-secure-bcc-is-safe

[Yuri D'Elia]

On Sun, Jan 22 2017, Jens Lechtenboerger wrote:
>> I'm not sure...  there might be subtleties there...  I've added Jens to
>> the Cc; he added the code so he might have an opinion.
>
> There was no particular reason for adding the bcc-check before
> executing that hook.  Feel free to exchange their order.

Lars, are you going to commit this change, or should I prep a patch?

Re: message.el and mml-secure-bcc-is-safe

[Lars Ingebrigtsen]

Yuri D'Elia <wavexx@thregr.org> writes:

> On Sun, Jan 22 2017, Jens Lechtenboerger wrote:
>>> I'm not sure...  there might be subtleties there...  I've added Jens to
>>> the Cc; he added the code so he might have an opinion.
>>
>> There was no particular reason for adding the bcc-check before
>> executing that hook.  Feel free to exchange their order.
>
> Lars, are you going to commit this change, or should I prep a patch?

Please prep a patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

[PATCH] Run 'mml-secure-bcc-is-safe after 'message-send-hook

[Yuri D'Elia]

If the hook modifies the message (mml tags or headers), we should check bcc on
the final message, not on the original.
---
 lisp/gnus/message.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 4f08b0b272..ce0dad9cb0 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -4119,8 +4119,8 @@ It should typically alter the sending method in some way or other."
   (let ((inhibit-read-only t))
     (put-text-property (point-min) (point-max) 'read-only nil))
   (message-fix-before-sending)
-  (mml-secure-bcc-is-safe)
   (run-hooks 'message-send-hook)
+  (mml-secure-bcc-is-safe)
   (when message-confirm-send
     (or (y-or-n-p "Send message? ")
 	(keyboard-quit)))
-- 
2.11.0

Re: [PATCH] Run 'mml-secure-bcc-is-safe after 'message-send-hook

[Lars Ingebrigtsen]

Yuri D'Elia <wavexx@thregr.org> writes:

> If the hook modifies the message (mml tags or headers), we should
> check bcc on the final message, not on the original.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no