unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuri D'Elia <wavexx@thregr.org>
To: emacs-devel@gnu.org
Subject: [PATCH] Run 'mml-secure-bcc-is-safe after 'message-send-hook
Date: Fri, 27 Jan 2017 15:37:24 +0100	[thread overview]
Message-ID: <87efzoy3ff.fsf_-_@wavexx.thregr.org> (raw)
In-Reply-To: 87vat3vz4s.fsf@gnus.org

If the hook modifies the message (mml tags or headers), we should check bcc on
the final message, not on the original.
---
 lisp/gnus/message.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 4f08b0b272..ce0dad9cb0 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -4119,8 +4119,8 @@ It should typically alter the sending method in some way or other."
   (let ((inhibit-read-only t))
     (put-text-property (point-min) (point-max) 'read-only nil))
   (message-fix-before-sending)
-  (mml-secure-bcc-is-safe)
   (run-hooks 'message-send-hook)
+  (mml-secure-bcc-is-safe)
   (when message-confirm-send
     (or (y-or-n-p "Send message? ")
 	(keyboard-quit)))
-- 
2.11.0





  reply	other threads:[~2017-01-27 14:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07 11:43 message.el and mml-secure-bcc-is-safe Yuri D'Elia
2017-01-21 16:34 ` Lars Ingebrigtsen
2017-01-22 13:44   ` Jens Lechtenboerger
2017-01-25 17:02     ` Yuri D'Elia
2017-01-25 17:16       ` Lars Ingebrigtsen
2017-01-27 14:37         ` Yuri D'Elia [this message]
2017-01-28 14:21           ` [PATCH] Run 'mml-secure-bcc-is-safe after 'message-send-hook Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efzoy3ff.fsf_-_@wavexx.thregr.org \
    --to=wavexx@thregr.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).