Re: [elpa] externals/ellama 3b077c0842 4/7: Call ellama-setup-keymap on prefix change

Re: [elpa] externals/ellama 3b077c0842 4/7: Call ellama-setup-keymap on prefix change

[Philip Kaludercic]

ELPA Syncer <elpasync@gnu.org> writes:

> branch: externals/ellama
> commit 3b077c0842941fa96295705b8414df628c25419c
> Author: Sergey Kostyaev <kostyaev.sergey2@wb.ru>
> Commit: Sergey Kostyaev <kostyaev.sergey2@wb.ru>
>
>     Call ellama-setup-keymap on prefix change
> ---
>  NEWS.org  | 3 +++
>  ellama.el | 6 +++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS.org b/NEWS.org
> index bf97cb2c43..3fddc7a6bb 100644
> --- a/NEWS.org
> +++ b/NEWS.org
> @@ -1,3 +1,6 @@
> +* Version 0.4.10
> +- Add customization group.
> +- Call ellama-setup-keymap on prefix change.
>  * Version 0.4.9
>  - Call fill-region only for non-programming modes.
>  * Version 0.4.8
> diff --git a/ellama.el b/ellama.el
> index 98e19337af..0bf1dec827 100644
> --- a/ellama.el
> +++ b/ellama.el
> @@ -6,7 +6,7 @@
>  ;; URL: http://github.com/s-kostyaev/ellama
>  ;; Keywords: help local tools
>  ;; Package-Requires: ((emacs "28.1") (llm "0.6.0") (spinner "1.7.4"))
> -;; Version: 0.4.9
> +;; Version: 0.4.10
>  ;; SPDX-License-Identifier: GPL-3.0-or-later
>  ;; Created: 8th Oct 2023
>  
> @@ -97,6 +97,10 @@
>  (defcustom ellama-keymap-prefix "C-c e"
>    "Key sequence for Ellama Commands."
>    :type 'string
> +  :set (lambda (symbol value)
> +	 (set symbol value)

AFAIK it is better to use a function like `set-default' or even
`custom-set-default'.

> +	 (when value
> +	   (ellama-setup-keymap)))
>    :group 'ellama)
>  
>  (defcustom ellama-ollama-binary (executable-find "ollama")