From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/ellama 3b077c0842 4/7: Call ellama-setup-keymap on prefix change Date: Tue, 26 Dec 2023 17:18:51 +0000 Message-ID: <87cyusswzo.fsf@posteo.net> References: <170353786620.20271.13080406788513813678@vcs2.savannah.gnu.org> <20231225205746.E0F24C004EC@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30012"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Sergey Kostyaev To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 26 18:19:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIB5S-0007fK-HE for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Dec 2023 18:19:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIB52-00015L-SJ; Tue, 26 Dec 2023 12:19:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIB51-00015D-Sx for emacs-devel@gnu.org; Tue, 26 Dec 2023 12:18:59 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIB50-0002r1-6T for emacs-devel@gnu.org; Tue, 26 Dec 2023 12:18:59 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D1CAE240101 for ; Tue, 26 Dec 2023 18:18:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703611134; bh=qPQg1KKQxUPgvX3DWdbtbuET32YHooKiAynU43GXI/E=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: From; b=pBCvNrQNLzsMQgj2wN0k24f3yo/B2mo4R/uf+QPsBmpSjGfeFYhk6ypMTH/22Wlam CgdvuKzcAlROfqyR8VnbiA/NBgR9yzwiXoOmmCy3rtrTMh/QTClLQFSvuUhk7OVDx/ rUqAkdsAeXRxnAHnymWtUG0zEhdtXsn3FIC9SyHV0Tkro2gXVVIMxhpBGu4nUOTASF XQrAtBJsH1xbpjPdSNHldVBEkoKjZi76U9qcaT1U8XEWn/R4AjKt2zsthpw4YR/WGC RwdpcdGYRHgaXsgjMzv2e8KrFA3TgGCYCD2tNlLXesRNkUz6HijLbUM2pm0ttpCROb +qPobLpOUlZrw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T01hZ0bCXz6tm4; Tue, 26 Dec 2023 18:18:53 +0100 (CET) In-Reply-To: <20231225205746.E0F24C004EC@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 25 Dec 2023 15:57:46 -0500 (EST)") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314228 Archived-At: ELPA Syncer writes: > branch: externals/ellama > commit 3b077c0842941fa96295705b8414df628c25419c > Author: Sergey Kostyaev > Commit: Sergey Kostyaev > > Call ellama-setup-keymap on prefix change > --- > NEWS.org | 3 +++ > ellama.el | 6 +++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/NEWS.org b/NEWS.org > index bf97cb2c43..3fddc7a6bb 100644 > --- a/NEWS.org > +++ b/NEWS.org > @@ -1,3 +1,6 @@ > +* Version 0.4.10 > +- Add customization group. > +- Call ellama-setup-keymap on prefix change. > * Version 0.4.9 > - Call fill-region only for non-programming modes. > * Version 0.4.8 > diff --git a/ellama.el b/ellama.el > index 98e19337af..0bf1dec827 100644 > --- a/ellama.el > +++ b/ellama.el > @@ -6,7 +6,7 @@ > ;; URL: http://github.com/s-kostyaev/ellama > ;; Keywords: help local tools > ;; Package-Requires: ((emacs "28.1") (llm "0.6.0") (spinner "1.7.4")) > -;; Version: 0.4.9 > +;; Version: 0.4.10 > ;; SPDX-License-Identifier: GPL-3.0-or-later > ;; Created: 8th Oct 2023 > > @@ -97,6 +97,10 @@ > (defcustom ellama-keymap-prefix "C-c e" > "Key sequence for Ellama Commands." > :type 'string > + :set (lambda (symbol value) > + (set symbol value) AFAIK it is better to use a function like `set-default' or even `custom-set-default'. > + (when value > + (ellama-setup-keymap))) > :group 'ellama) > > (defcustom ellama-ollama-binary (executable-find "ollama")