From: Philip Kaludercic <philipk@posteo.net>
To: emacs-devel@gnu.org
Cc: Sergey Kostyaev <kostyaev.sergey2@wb.ru>
Subject: Re: [elpa] externals/ellama 3b077c0842 4/7: Call ellama-setup-keymap on prefix change
Date: Tue, 26 Dec 2023 17:18:51 +0000 [thread overview]
Message-ID: <87cyusswzo.fsf@posteo.net> (raw)
In-Reply-To: <20231225205746.E0F24C004EC@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 25 Dec 2023 15:57:46 -0500 (EST)")
ELPA Syncer <elpasync@gnu.org> writes:
> branch: externals/ellama
> commit 3b077c0842941fa96295705b8414df628c25419c
> Author: Sergey Kostyaev <kostyaev.sergey2@wb.ru>
> Commit: Sergey Kostyaev <kostyaev.sergey2@wb.ru>
>
> Call ellama-setup-keymap on prefix change
> ---
> NEWS.org | 3 +++
> ellama.el | 6 +++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/NEWS.org b/NEWS.org
> index bf97cb2c43..3fddc7a6bb 100644
> --- a/NEWS.org
> +++ b/NEWS.org
> @@ -1,3 +1,6 @@
> +* Version 0.4.10
> +- Add customization group.
> +- Call ellama-setup-keymap on prefix change.
> * Version 0.4.9
> - Call fill-region only for non-programming modes.
> * Version 0.4.8
> diff --git a/ellama.el b/ellama.el
> index 98e19337af..0bf1dec827 100644
> --- a/ellama.el
> +++ b/ellama.el
> @@ -6,7 +6,7 @@
> ;; URL: http://github.com/s-kostyaev/ellama
> ;; Keywords: help local tools
> ;; Package-Requires: ((emacs "28.1") (llm "0.6.0") (spinner "1.7.4"))
> -;; Version: 0.4.9
> +;; Version: 0.4.10
> ;; SPDX-License-Identifier: GPL-3.0-or-later
> ;; Created: 8th Oct 2023
>
> @@ -97,6 +97,10 @@
> (defcustom ellama-keymap-prefix "C-c e"
> "Key sequence for Ellama Commands."
> :type 'string
> + :set (lambda (symbol value)
> + (set symbol value)
AFAIK it is better to use a function like `set-default' or even
`custom-set-default'.
> + (when value
> + (ellama-setup-keymap)))
> :group 'ellama)
>
> (defcustom ellama-ollama-binary (executable-find "ollama")
parent reply other threads:[~2023-12-26 17:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20231225205746.E0F24C004EC@vcs2.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyusswzo.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=kostyaev.sergey2@wb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).