From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` Date: Thu, 04 Mar 2021 01:47:28 +0000 Message-ID: <87blbzd70v.fsf@tcd.ie> References: <20210301171853.8051.45984@vcs0.savannah.gnu.org> <20210301171854.C42CB20E1B@vcs0.savannah.gnu.org> <87h7lsthzh.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38616"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 02:49:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHd6o-0009tY-1y for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 02:48:58 +0100 Original-Received: from localhost ([::1]:60856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHd6m-00066b-U1 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 20:48:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHd5V-0005dZ-Hc for emacs-devel@gnu.org; Wed, 03 Mar 2021 20:47:38 -0500 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:37939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHd5R-0006z1-OR for emacs-devel@gnu.org; Wed, 03 Mar 2021 20:47:36 -0500 Original-Received: by mail-wr1-x436.google.com with SMTP id d15so10601003wrv.5 for ; Wed, 03 Mar 2021 17:47:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9kfTBd2V+7yghn6oRqL2fs9bEH24CF4hpu62lWylunM=; b=OhUd7ZfyOoFij2URcFR4UBApaqDvjSYJfrXidPBK0sOrRn/LhtaRHdq0MwpCbAMQLU QsOv3prEWZ/8KXPuLsAfMgnjpTUfWwe79aOawBt3icCVY//6ahT8ABoGVS7uBZOQyoCQ yLI08QApDEo9pg5N78zO73PUZtGBU3QwsnHw/r/1HIxCblI3r2iIhl1cZTE0XKnoui5w 7NFkQsIDF6wyD8/ng3utlR71/BLmCeAeYIP+Jrf86+z3g0v5pOykd9NT0foAA8aloUeB cEP0585tytn0yXEQckAX8Yy5Q7729NHns/k1w14wLFo+xkEoAY4dbVrPG7UH6aE6pW6V RiVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9kfTBd2V+7yghn6oRqL2fs9bEH24CF4hpu62lWylunM=; b=GY0xxsGLoNa7X9Oq1UP0v4U4uXoaqAhWsXEHpfcxJFwVhE39ich1NkJIYTnpUi5ccH zWn4UEp/QVw7RaMhSe/rI1HuyXtZAAQY6So/up292X/VwLQTnnS4EmaGeezCvm+B4I0n AU2MFjIUmjotLvEjsPPe7bK9ecWflGzOWCcyWbWu+FvROXsnIqDdH26OBb7d/BhWJ+LG tLZZkKyP+fJEAgUBj+rlg389mUN46EV/9kcYyrZKJxAn8I5Iz1Z4+9PLP6NpTza5J6/D vJI5vpsBkHw26SMxv1i3wSVALVfv5bG0LLPjai44LXcbZ9K+GVmc/6C4Sk21Yp99tFb+ yp7Q== X-Gm-Message-State: AOAM530zoqcSzwA8rgo6zZBfSCO1ialERTkZW7tczlSND1WQ3k8F10rn 5PhiSpRmg9jt2KCYfphwoyYgQg== X-Google-Smtp-Source: ABdhPJzbANmXJNGbM3sYynKbgkCZmDvQusQPs13qjh2S8ejd0MsLi0vVSUGgffKqUpt3++0/jBxBPQ== X-Received: by 2002:a5d:5043:: with SMTP id h3mr1436930wrt.120.1614822451190; Wed, 03 Mar 2021 17:47:31 -0800 (PST) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id 91sm11786305wrl.20.2021.03.03.17.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 17:47:30 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 03 Mar 2021 17:15:59 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=contovob@tcd.ie; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265926 Archived-At: Stefan Monnier writes: >>> Fix misuses of `byte-compile-macro-environment` >> >> This seems to result in the following test failure with 'make check', >> but strangely not with 'make test/pcase-tests': > > Hmm... I wonder why the test code worked before that patch. > The problem is that pcase macros defined with `pcase-defmacro` can't be > used in the same file where they're defined (you need to wrap them in > `eval-and-compile`). > Maybe we should fix that, but the problem is not new, so I'm wondering > why the bug didn't trigger earlier. Beats me :/. Even after reverting commits a0f60293d9 and 88ca2280ba, 'make check' still fails. But both 'git bisect', and checking out its parent 6ad9b8d677, point to a0f60293d9 as being the culprit. >> BTW, 'make bootstrap' now emits this warning: >> >> In cl--sm-macroexpand: >> emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare' > > Yes, that's good: the warning wanrs about an actual problem. > >> (The 'sm' is the artist's signature, right? ;) > > Nah, the artist found a good excuse: "s(ymbol-)m(acrolet)" Not the kind of nom de plume you see every day. >> Is this the right fix? > > Yes, but it doesn't just pacify the byte-compiler: it fixes the source > code (in Emacs-27, this worked by accident, really). Thanks, pushed with the log message adapted accordingly. -- Basil