Re: master c8bde5b0a3: Fix two no-X compilation warnings

Re: master c8bde5b0a3: Fix two no-X compilation warnings

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> -  (or (stringp x-resource-name)
> +  (when (boundp 'x-resource-name)
> +    (unless (stringp x-resource-name)
>        (let (i)
>  	(setq x-resource-name (copy-sequence invocation-name))
>  
>  	;; Change any . or * characters in x-resource-name to hyphens,
>  	;; so as not to choke when we use it in X resource queries.
>  	(while (setq i (string-match "[.*]" x-resource-name))
> -	  (aset x-resource-name i ?-))))
> +	  (aset x-resource-name i ?-)))))
>  
>    ;; Setup the default fontset.
>    (create-default-fontset)

I thought the right thing to do in this particular situation was to add
a defvar form that read something like this:

(defvar x-resource-name)

Thanks.

Re: master c8bde5b0a3: Fix two no-X compilation warnings

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> I thought the right thing to do in this particular situation was to add
> a defvar form that read something like this:
>
> (defvar x-resource-name)

That would hide the compilation warning, too -- but if the code actually
ends up being called, it'll bug out.  (That's not very likely in this
case, though.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c8bde5b0a3: Fix two no-X compilation warnings

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> I thought the right thing to do in this particular situation was to add
>> a defvar form that read something like this:
>>
>> (defvar x-resource-name)
>
> That would hide the compilation warning, too -- but if the code actually
> ends up being called, it'll bug out.  (That's not very likely in this
> case, though.)

Hmm, thanks for explaining.  But I thought defvar didn't do anything
with variables that are already defined, such as in C code.

Thanks.

Re: master c8bde5b0a3: Fix two no-X compilation warnings

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Hmm, thanks for explaining.  But I thought defvar didn't do anything
> with variables that are already defined, such as in C code.

They don't.  But if you call the code that use those variables (that
aren't defined), the code will error out.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c8bde5b0a3: Fix two no-X compilation warnings

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> They don't.  But if you call the code that use those variables (that
> aren't defined), the code will error out.

That code in particular can never be called outside PGTK, I think, so I
wouldn't be worried about that.

But thanks for explaining.

Re: master c8bde5b0a3: Fix two no-X compilation warnings

[Andreas Schwab]

On Mär 23 2022, Lars Ingebrigtsen wrote:

> They don't.  But if you call the code that use those variables (that
> aren't defined), the code will error out.

But term/pgtk-win is only ever loaded when x-resource-name is defined.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."