From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master c8bde5b0a3: Fix two no-X compilation warnings Date: Wed, 23 Mar 2022 08:55:03 +0800 Message-ID: <874k3pebdk.fsf@yahoo.com> References: <164798008014.25625.1667266381969929314@vcs2.savannah.gnu.org> <20220322201440.6B4ABC01680@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12245"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 23 01:56:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWpIj-0002xF-K5 for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Mar 2022 01:56:37 +0100 Original-Received: from localhost ([::1]:39396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWpIh-0006pT-Mb for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Mar 2022 20:56:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWpHP-00068k-Ka for emacs-devel@gnu.org; Tue, 22 Mar 2022 20:55:15 -0400 Original-Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]:42307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nWpHN-0000dl-0U for emacs-devel@gnu.org; Tue, 22 Mar 2022 20:55:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647996911; bh=UPDpnvJiLCzHfR1obvP+/WZtDh5lu46w546fIAR5XOw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=tnf1oUvB28v/5rHHA6m9EyVv3gRF7p61VqlXZgtaFmj3xZkLBU3bnc7J9HuNwll25+BAqaYkUtptAt7mQvWVNh+0dyEscfrAHI1v6XXwTrLYTD9pr/MXyA2j308gA7UFP9/e2fmE8WVy/cWg5nLQEmIUP5KAsnUkLLgfxOEaxTyM3QLtG5XIaUYvzlUCIEYl/FjfVP5XNEmWXBXfQG/wMODw1aipZ5MSL5EWTw0QgiKx2K+iqmrCZXmvymhBFIdYBVojGJTP8t46UaDK9WzCt7zwuSa4ce3RTkqF7ppL7XTCn4/sy1152k/VwrmyIiwir+8TTEK4tXQ5Xk54g2sSxA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647996911; bh=M7I6tocC/7lxd8HLnxTUsCwXGotjtvW1v+MFd915XBo=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=eOB/fXJXWeBf+avQkr6fJqVY0MbmYd03zj02nhPI5w088CjyPBJc3+6oQe7Ogrprdzx3HpU7/mtT2Ee8GgustkmvRWyisxuT9blw2uPbN/cPsBr8V7AVJTRLvftXWbNwE48D0sE+aRF3eneJcwYkruuUcQtc0dPWTwiDu/zhK4cUJrD5j6jOIsyp8do5aY4Zn+5/7pkRCD+N9hR4hDa6FoTLFuEY3XrGHBscCwOw9G+YnnwXNtDTII+QJg6Sw7B4rKGclS8bOINZSkZhlZKY/MGTl4RGARz2LULUQ29ntR86gExiJjQUYcd9F+w8bAVFJfTEb5pcverUs9S1cDd0bQ== X-YMail-OSG: QNBr3eQVM1kqYVXz4g0gkeoAvkYVDzDnwsfGiOXXSAe7rQk1XCK0G7SDG28HOtq DMEDbUDVvy.y7IJhN29mwJu8UM5xXIvxQa.ddH11FdDJKbmKum7IJxIqXGiECSHNUYB2s4U_UyGs dz1ez8q25IwbeIQAEMMgSJopHBtIPnFCpj8wSv8H4Cx6n7Lzh8Und.7uHZOEsK9Qc3343YDrNy51 yhwRpoPfl96FeFsKIslFfb3OYL38KDWPNbYD9oiELuDZ944FUzbwMNzPTv0HU_JGwiMFpfR0LcYq t.nTdzDZ5Ncva8grRmgPIpqfDnx9Umy.HYUmI.AGBjis.vr8Gp7Elko0YxExwNmnR7VRvr__7fhJ tH_npHWOssWtPXY9CZO7mbCZYaXmXNA7tFEwV4OMUw.7kbUDe4P.Fn7GjnE1Sn5_RD3WEH6Z.sFy nGt_bPuXxocZdpCQ47LIwNZlyWgJ1cET2s7V0Z1bwA1oXgyBhWVh9uy81U1n3SOHj.arwAJuaolj viurFlKEl2b80Ncr3flxyjmjpdo6q2k0HlK86eTkWhnTxj0hUvdTCmC3BBi25eLzHaLtBzwXJuOo Ml.FDVJhMT.fldwwVUAo.YYYzFZyQKy9ZbDvalNFFaeh9NDYhXsZJd3PpS_7Rbu2_H5.KPwYHR6c m913bC85usn.hsC7ubkfzbx3krWOD0rkGgsd0wj57cqwrinw25YP0mul7qQUDXlZ0S3EKencHxVy wVKJ9yc7w0ZAEaxl0ZLm9Lh81KCJmJdG8xE3xf1H0WJ9mxSgsci6Eclkt9uSpQ4i2qpIThFt3Da4 uM4bGOUMX2qzoXVSIWlsY3W7eAryR18VeH7yT6p4Mm X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Wed, 23 Mar 2022 00:55:11 +0000 Original-Received: by kubenode516.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7b6472bc85b13294ecf691243a6114fe; Wed, 23 Mar 2022 00:55:07 +0000 (UTC) In-Reply-To: <20220322201440.6B4ABC01680@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 22 Mar 2022 16:14:40 -0400 (EDT)") X-Mailer: WebService/1.1.19894 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.184.199; envelope-from=luangruo@yahoo.com; helo=sonic301-30.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287376 Archived-At: Lars Ingebrigtsen writes: > - (or (stringp x-resource-name) > + (when (boundp 'x-resource-name) > + (unless (stringp x-resource-name) > (let (i) > (setq x-resource-name (copy-sequence invocation-name)) > > ;; Change any . or * characters in x-resource-name to hyphens, > ;; so as not to choke when we use it in X resource queries. > (while (setq i (string-match "[.*]" x-resource-name)) > - (aset x-resource-name i ?-)))) > + (aset x-resource-name i ?-))))) > > ;; Setup the default fontset. > (create-default-fontset) I thought the right thing to do in this particular situation was to add a defvar form that read something like this: (defvar x-resource-name) Thanks.