From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master c8bde5b0a3: Fix two no-X compilation warnings Date: Wed, 23 Mar 2022 12:17:07 +0100 Message-ID: <8735j8c40c.fsf@gnus.org> References: <164798008014.25625.1667266381969929314@vcs2.savannah.gnu.org> <20220322201440.6B4ABC01680@vcs2.savannah.gnu.org> <874k3pebdk.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 23 12:20:16 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWz2F-0008oa-Ot for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Mar 2022 12:20:15 +0100 Original-Received: from localhost ([::1]:33366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWz2E-0003Km-IZ for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Mar 2022 07:20:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWyzL-0000V4-Qv for emacs-devel@gnu.org; Wed, 23 Mar 2022 07:17:15 -0400 Original-Received: from [2a01:4f9:2b:f0f::2] (port=34558 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWyzK-0001VM-2S for emacs-devel@gnu.org; Wed, 23 Mar 2022 07:17:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jcFeQgk7TQUHGcTEE5FgUEbAO6XLA1TTXI7PR6sInLM=; b=OZbgowCk95I0NiBtC1UR/RkEfq kYtI0cInWRdom67E9TB8CbAl4yeMdutN8WrBVoSfSB+pKzJgtii9MwbBdlhdax8clf1ok3J51+30m 3wZGEUib69Ltilr1fg1PBzRoqO3a9RXO7iZ0Vyp2lSj2vXX/SOD+FzZIHPLJGU51ZJCk=; Original-Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWyzF-0002bM-D7; Wed, 23 Mar 2022 12:17:11 +0100 In-Reply-To: <874k3pebdk.fsf@yahoo.com> (Po Lu's message of "Wed, 23 Mar 2022 08:55:03 +0800") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287384 Archived-At: Po Lu writes: > I thought the right thing to do in this particular situation was to add > a defvar form that read something like this: > > (defvar x-resource-name) That would hide the compilation warning, too -- but if the code actually ends up being called, it'll bug out. (That's not very likely in this case, though.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no