unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: perry@piermont.com, deng@randomsample.de, emacs-devel@gnu.org
Subject: Re: Speed of keyboard macro execution?
Date: Thu, 10 Dec 2015 21:09:59 +0100	[thread overview]
Message-ID: <877fkmt694.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <837fkm9ire.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Dec 2015 22:00:05 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: David Kastrup <dak@gnu.org>
>> Cc: emacs-devel@gnu.org,  deng@randomsample.de,  perry@piermont.com
>> Date: Thu, 10 Dec 2015 20:38:58 +0100
>> 
>> >> Tying the operation of keyboard macros to the current display/font
>> >> selection is just meaningless.  Its purpose is for _aiming_ positioning
>> >> by keyboard, and that's just not useful at keyboard replay.
>> >
>> > I think it depends on the keyboard macro.  The ones I saw in that demo
>> > did move point, moreover they moved it to the end of a very long line,
>> > so both the actual redisplay and its simulation were at work,
>> > including auto-hscroll.
>> 
>> So how did line-move-visual accomplish anything useful here?
>
> One example is vertical-motion, and many commands that call it.  E.g.,
> if the macro invokes C-n.

Uh WHAT?

    C-n runs the command next-line (found in global-map), which is an
    interactive compiled Lisp function in ‘simple.el’.

    This function is for interactive use only;
    in Lisp code use ‘forward-line’ instead.

There is a reason this function is for interactive use only.  And
replaying a keyboard macro is not interactive.

    If the variable ‘line-move-visual’ is non-nil, this command moves
    by display lines.  Otherwise, it moves by buffer lines, without
    taking variable-width characters or continued lines into account.

And this is _exactly_ why line-move-visual should be nil during macro
recording/replay because otherwise _no_ _useful_ behavior for
non-interactive use results.

>> Which occured during keyboard macro execution due to line-move-visual
>> being active.
>
> No, not necessarily.  Rather, the original issue with keyboard macros
> is just one of the scenarios that brings the broader problem to light,
> if the macro invokes one of the affected commands.

No argument here.  I'm not against fixing the redisplay problem.  I'm
against involving display-based movement in keyboard macros.

>> So I think it would make excellent sense to disable visual
>> positioning modes while recording and replaying keyboard macros.
>
> No, I think you are wrong.  Think C-n and C-p again.

That's exactly the reason for me wanting to disable visual positioning
modes while recording and replaying keyboard macros.

I mean, obviously I would not proposing it if I thought it should not
make a difference.

So I have no idea what your argument here is supposed to be.

-- 
David Kastrup



  reply	other threads:[~2015-12-10 20:09 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09 21:39 Speed of keyboard macro execution? Perry E. Metzger
2015-12-09 22:13 ` David Engster
2015-12-09 23:03   ` Perry E. Metzger
2015-12-10 16:43     ` Eli Zaretskii
2015-12-10 17:00       ` Perry E. Metzger
2015-12-10 17:14         ` John Wiegley
2015-12-10 17:27         ` David Engster
2015-12-10 17:33           ` Perry E. Metzger
2015-12-10 17:39             ` David Engster
2015-12-10 17:53             ` Eli Zaretskii
2015-12-10 18:10               ` Perry E. Metzger
2015-12-10 18:41                 ` Eli Zaretskii
2015-12-10 18:44               ` David Kastrup
2015-12-10 18:57                 ` Eli Zaretskii
2015-12-10 19:38                   ` David Kastrup
2015-12-10 20:00                     ` Eli Zaretskii
2015-12-10 20:09                       ` David Kastrup [this message]
2015-12-10 20:43                         ` Eli Zaretskii
2015-12-10 20:55                           ` David Kastrup
2015-12-10 20:16                       ` Perry E. Metzger
2015-12-10 20:18                         ` John Wiegley
2015-12-10 20:36                           ` David Kastrup
2015-12-10 20:43                             ` John Wiegley
2015-12-10 21:01                               ` David Kastrup
2015-12-10 21:26                                 ` John Wiegley
2015-12-10 23:35                                   ` David Kastrup
2015-12-11  1:14                                     ` John Wiegley
2015-12-11  6:27                                       ` David Kastrup
2015-12-12 22:56                                         ` John Wiegley
2015-12-12 23:46                                           ` David Kastrup
2015-12-13  0:16                                             ` John Wiegley
2015-12-13  0:32                                               ` David Kastrup
2015-12-12 23:20                                     ` Per Starbäck
2015-12-12 16:51                                   ` Perry E. Metzger
2015-12-12 17:42                                     ` David Kastrup
2015-12-12 23:01                                     ` Disabling visual lines for macros (was: Speed of keyboard macro execution?) John Wiegley
2015-12-12 23:33                                       ` Disabling visual lines for macros David Kastrup
2015-12-10 20:45                             ` Speed of keyboard macro execution? Perry E. Metzger
2015-12-10 20:50                               ` John Wiegley
2015-12-10 20:48                             ` Eli Zaretskii
2015-12-10 20:50                               ` John Wiegley
2015-12-10 21:13                               ` David Kastrup
2015-12-10 17:37         ` Eli Zaretskii
2015-12-10 17:43           ` John Wiegley
2015-12-10 17:54             ` Eli Zaretskii
2015-12-10 18:15       ` Achim Gratz
2015-12-10 18:47         ` Eli Zaretskii
2015-12-12  2:14       ` Joseph Mingrone
2015-12-12  7:39         ` Eli Zaretskii
2015-12-12 17:28           ` Joseph Mingrone
2015-12-12 17:57             ` Eli Zaretskii
2015-12-12 18:12               ` Joseph Mingrone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fkmt694.fsf@fencepost.gnu.org \
    --to=dak@gnu.org \
    --cc=deng@randomsample.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=perry@piermont.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).