* Re: emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars
[not found] ` <20211122180209.906C1209FD@vcs0.savannah.gnu.org>
@ 2021-11-23 8:39 ` Lars Ingebrigtsen
2021-11-23 12:39 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-23 8:39 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
eliz@gnu.org (Eli Zaretskii) writes:
> Fix '(space :relative-width N)' display spec w/non-ASCII chars
This apparently leads to the following compilation warning (on master,
at least):
In file included from composite.h:29,
from xdisp.c:441:
xdisp.c: In function 'produce_stretch_glyph':
dispextern.h:1891:10: warning: 'face' may be used uninitialized in this function [-Wmaybe-uninitialized]
1891 | return face_for_char (f, face, character, pos, object);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xdisp.c:30063:16: note: 'face' was declared here
30063 | struct face *face;
| ^~~~
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars
2021-11-23 8:39 ` emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars Lars Ingebrigtsen
@ 2021-11-23 12:39 ` Eli Zaretskii
2021-11-24 6:59 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-11-23 12:39 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 23 Nov 2021 09:39:13 +0100
>
> eliz@gnu.org (Eli Zaretskii) writes:
>
> > Fix '(space :relative-width N)' display spec w/non-ASCII chars
>
> This apparently leads to the following compilation warning (on master,
> at least):
>
> In file included from composite.h:29,
> from xdisp.c:441:
> xdisp.c: In function 'produce_stretch_glyph':
> dispextern.h:1891:10: warning: 'face' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 1891 | return face_for_char (f, face, character, pos, object);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> xdisp.c:30063:16: note: 'face' was declared here
> 30063 | struct face *face;
> | ^~~~
Stupid compiler, which cannot get its act together wrt conditions,
shouldn't attempt to issue warnings about code it didn't understand.
I hope I fixed this now (assuming we won't see a different bogus
warning).
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars
2021-11-23 12:39 ` Eli Zaretskii
@ 2021-11-24 6:59 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-11-24 6:59 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> I hope I fixed this now (assuming we won't see a different bogus
> warning).
Yup; that fixed the warning here.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-24 6:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211122180208.16961.66097@vcs0.savannah.gnu.org>
[not found] ` <20211122180209.906C1209FD@vcs0.savannah.gnu.org>
2021-11-23 8:39 ` emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars Lars Ingebrigtsen
2021-11-23 12:39 ` Eli Zaretskii
2021-11-24 6:59 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).