From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars Date: Tue, 23 Nov 2021 14:39:48 +0200 Message-ID: <83k0gzoxkb.fsf@gnu.org> References: <20211122180208.16961.66097@vcs0.savannah.gnu.org> <20211122180209.906C1209FD@vcs0.savannah.gnu.org> <87lf1ffeq6.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 23 13:51:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpVGN-0004wG-Ov for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Nov 2021 13:51:07 +0100 Original-Received: from localhost ([::1]:39506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpVGJ-00017s-Ql for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Nov 2021 07:51:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58974) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpV5I-0003f9-Fg for emacs-devel@gnu.org; Tue, 23 Nov 2021 07:39:41 -0500 Original-Received: from [2001:470:142:3::e] (port=43388 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpV5G-0000wY-K7; Tue, 23 Nov 2021 07:39:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fuDUEwI0OdkP6+V965kktYVRFe0D95W7uWYwqleA2fA=; b=q1OAsq0t32Hf ap4b0R81NwhurQRbWSofaxDut32qfHt/xO3JVMz6cdn6oGVNWxWBtCGM0tp7NSQOhMMmdUqmolrBD N2cZXypKAJb7Nq8ddtzu05GMWiIduo+9/Wq+0VFdjrRPoyFHwwYebqseGAM4KIObCd5pJUJqYpEH9 3AgL5osM2Y1rzxNlXorz2+CHwzg6eUI1uGzhFfnXnlqaO9XG1jEYw8fOsjOyHiMJGsUDCDrGFCJdq ZHotsTF1ezocRdw8GRVrHk6bskGfX04mFwKAwaOmyy3ZGs+7IpHVHXvy8oOL1YqwgujcgScEvkdck +rlpB4+SLS6UpNpjKoCmRw==; Original-Received: from [87.69.77.57] (port=4995 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpV5G-0004oW-9u; Tue, 23 Nov 2021 07:39:38 -0500 In-Reply-To: <87lf1ffeq6.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 23 Nov 2021 09:39:13 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279946 Archived-At: > From: Lars Ingebrigtsen > Cc: Eli Zaretskii > Date: Tue, 23 Nov 2021 09:39:13 +0100 > > eliz@gnu.org (Eli Zaretskii) writes: > > > Fix '(space :relative-width N)' display spec w/non-ASCII chars > > This apparently leads to the following compilation warning (on master, > at least): > > In file included from composite.h:29, > from xdisp.c:441: > xdisp.c: In function 'produce_stretch_glyph': > dispextern.h:1891:10: warning: 'face' may be used uninitialized in this function [-Wmaybe-uninitialized] > 1891 | return face_for_char (f, face, character, pos, object); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > xdisp.c:30063:16: note: 'face' was declared here > 30063 | struct face *face; > | ^~~~ Stupid compiler, which cannot get its act together wrt conditions, shouldn't attempt to issue warnings about code it didn't understand. I hope I fixed this now (assuming we won't see a different bogus warning). Thanks.