From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars
Date: Tue, 23 Nov 2021 14:39:48 +0200 [thread overview]
Message-ID: <83k0gzoxkb.fsf@gnu.org> (raw)
In-Reply-To: <87lf1ffeq6.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 23 Nov 2021 09:39:13 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 23 Nov 2021 09:39:13 +0100
>
> eliz@gnu.org (Eli Zaretskii) writes:
>
> > Fix '(space :relative-width N)' display spec w/non-ASCII chars
>
> This apparently leads to the following compilation warning (on master,
> at least):
>
> In file included from composite.h:29,
> from xdisp.c:441:
> xdisp.c: In function 'produce_stretch_glyph':
> dispextern.h:1891:10: warning: 'face' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 1891 | return face_for_char (f, face, character, pos, object);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> xdisp.c:30063:16: note: 'face' was declared here
> 30063 | struct face *face;
> | ^~~~
Stupid compiler, which cannot get its act together wrt conditions,
shouldn't attempt to issue warnings about code it didn't understand.
I hope I fixed this now (assuming we won't see a different bogus
warning).
Thanks.
next prev parent reply other threads:[~2021-11-23 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211122180208.16961.66097@vcs0.savannah.gnu.org>
[not found] ` <20211122180209.906C1209FD@vcs0.savannah.gnu.org>
2021-11-23 8:39 ` emacs-28 d791cd5: Fix '(space :relative-width N)' display spec w/non-ASCII chars Lars Ingebrigtsen
2021-11-23 12:39 ` Eli Zaretskii [this message]
2021-11-24 6:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0gzoxkb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).