Re: feature/tree-sitter 06db8015ea 1/5: Extract out treesit_make_ranges

Re: feature/tree-sitter 06db8015ea 1/5: Extract out treesit_make_ranges

[Po Lu]

Yuan Fu <casouri@gmail.com> writes:

> +/* Generate a list of ranges in Lisp from RANGES.  This function
> +   doens't take ownership of RANGES.  BUFFER is used to convert
> +   between tree-sitter buffer offset and buffer position.  */
> +static Lisp_Object
> +treesit_make_ranges (const TSRange *ranges, uint32_t len,
> +		     struct buffer *buffer)
> +{
> +  Lisp_Object list = Qnil;
> +  for (int idx = 0; idx < len; idx++)
> +    {
> +      TSRange range = ranges[idx];
> +      uint32_t beg_byte = range.start_byte + BUF_BEGV_BYTE (buffer);
> +      uint32_t end_byte = range.end_byte + BUF_BEGV_BYTE (buffer);
> +      eassert (BUF_BEGV_BYTE (buffer) <= beg_byte);
> +      eassert (beg_byte <= end_byte);
> +      eassert (end_byte <= BUF_ZV_BYTE (buffer));
> +
> +      Lisp_Object lisp_range
> +	= Fcons (make_fixnum (buf_bytepos_to_charpos (buffer, beg_byte)),
> +		 make_fixnum (buf_bytepos_to_charpos (buffer, end_byte)));
> +      list = Fcons (lisp_range, list);
> +    }
> +  return Fnreverse (list);
> +
> +}

There is a trailing newline after "return Fnreverse..."

Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes

[Po Lu]

Yuan Fu <casouri@gmail.com> writes:

> +static Lisp_Object
> +treesit_make_ranges (const TSRange *, uint32_t, struct buffer *);

This should be:

static Lisp_Object treesit_make_ranges (const TSRange *, uint32_t,
					struct buffer *);

> +  Lisp_Object lisp_ranges = treesit_make_ranges(ranges, len, buf);

There is a missing space between "treesit_make_ranges" and its
parameters.

> +  FOR_EACH_TAIL (functions)
> +    safe_call2(XCAR (functions), lisp_ranges, parser);

Here too, between safe_call2 and the parameters.

> +      treesit_call_after_change_functions(tree, new_tree, parser);

And here.

> +DEFUN ("treesit-parser-notifiers",
> +       Ftreesit_parser_notifiers,
> +       Streesit_parser_notifiers,

> +
> +DEFUN ("treesit-parser-add-notifier",
> +       Ftreesit_parser_add_notifier,
> +       Streesit_parser_add_notifier,

> +
> +DEFUN ("treesit-parser-remove-notifier",
> +       Ftreesit_parser_remove_notifier,
> +       Streesit_parser_remove_notifier,

Can't you put all of these on one line?

Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes

[Yuan Fu]

> On Nov 15, 2022, at 3:54 AM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> +static Lisp_Object
>> +treesit_make_ranges (const TSRange *, uint32_t, struct buffer *);
> 
> This should be:
> 
> static Lisp_Object treesit_make_ranges (const TSRange *, uint32_t,
> 					struct buffer *);
> 
>> +  Lisp_Object lisp_ranges = treesit_make_ranges(ranges, len, buf);
> 
> There is a missing space between "treesit_make_ranges" and its
> parameters.
> 
>> +  FOR_EACH_TAIL (functions)
>> +    safe_call2(XCAR (functions), lisp_ranges, parser);
> 
> Here too, between safe_call2 and the parameters.
> 
>> +      treesit_call_after_change_functions(tree, new_tree, parser);
> 
> And here.
> 
>> +DEFUN ("treesit-parser-notifiers",
>> +       Ftreesit_parser_notifiers,
>> +       Streesit_parser_notifiers,
> 
>> +
>> +DEFUN ("treesit-parser-add-notifier",
>> +       Ftreesit_parser_add_notifier,
>> +       Streesit_parser_add_notifier,
> 
>> +
>> +DEFUN ("treesit-parser-remove-notifier",
>> +       Ftreesit_parser_remove_notifier,
>> +       Streesit_parser_remove_notifier,
> 
> Can't you put all of these on one line?

All fixed! Thanks. BTW how do you send an email like this, with the tile being the commit message and everything?

Yuan

Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes

[Eli Zaretskii]

> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 15 Nov 2022 09:25:27 -0800
> Cc: emacs-devel@gnu.org
> 
> BTW how do you send an email like this, with the tile being the commit message and everything?

See https://lists.gnu.org/archive/html/emacs-diffs/2022-11/index.html.

Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes

[Visuwesh]

[செவ்வாய் நவம்பர் 15, 2022] Yuan Fu wrote:

> BTW how do you send an email like this, with the tile being the commit message and everything?

I believe Po Lu follows emacs-diffs.  All emacs-diffs messages have the
subject as the commit summary and the entire commit in the body, and
they have the mail headers set up so that the messaege is sent to the
commit author whilst having emacs-devel in the CC's.

> Yuan

Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes

[Yuan Fu]

>> From: Yuan Fu <casouri@gmail.com>
>> Date: Tue, 15 Nov 2022 09:25:27 -0800
>> Cc: emacs-devel@gnu.org
>> 
>> BTW how do you send an email like this, with the tile being the commit message and everything?
> 
> See https://lists.gnu.org/archive/html/emacs-diffs/2022-11/index.html.

> On Nov 15, 2022, at 10:06 AM, Visuwesh <visuweshm@gmail.com> wrote:
> 
> [செவ்வாய் நவம்பர் 15, 2022] Yuan Fu wrote:
> 
>> BTW how do you send an email like this, with the tile being the commit message and everything?
> 
> I believe Po Lu follows emacs-diffs.  All emacs-diffs messages have the
> subject as the commit summary and the entire commit in the body, and
> they have the mail headers set up so that the messaege is sent to the
> commit author whilst having emacs-devel in the CC's.
> 
>> Yuan

Ahhh, how nice. Thanks to you both! Subscribing to yet one more emacs ML ;-)

Yuan