From: Yuan Fu <casouri@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes
Date: Tue, 15 Nov 2022 09:25:27 -0800 [thread overview]
Message-ID: <AFD32557-2453-45A9-9E32-A4E960916869@gmail.com> (raw)
In-Reply-To: <877czwh1q4.fsf@yahoo.com>
> On Nov 15, 2022, at 3:54 AM, Po Lu <luangruo@yahoo.com> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> +static Lisp_Object
>> +treesit_make_ranges (const TSRange *, uint32_t, struct buffer *);
>
> This should be:
>
> static Lisp_Object treesit_make_ranges (const TSRange *, uint32_t,
> struct buffer *);
>
>> + Lisp_Object lisp_ranges = treesit_make_ranges(ranges, len, buf);
>
> There is a missing space between "treesit_make_ranges" and its
> parameters.
>
>> + FOR_EACH_TAIL (functions)
>> + safe_call2(XCAR (functions), lisp_ranges, parser);
>
> Here too, between safe_call2 and the parameters.
>
>> + treesit_call_after_change_functions(tree, new_tree, parser);
>
> And here.
>
>> +DEFUN ("treesit-parser-notifiers",
>> + Ftreesit_parser_notifiers,
>> + Streesit_parser_notifiers,
>
>> +
>> +DEFUN ("treesit-parser-add-notifier",
>> + Ftreesit_parser_add_notifier,
>> + Streesit_parser_add_notifier,
>
>> +
>> +DEFUN ("treesit-parser-remove-notifier",
>> + Ftreesit_parser_remove_notifier,
>> + Streesit_parser_remove_notifier,
>
> Can't you put all of these on one line?
All fixed! Thanks. BTW how do you send an email like this, with the tile being the commit message and everything?
Yuan
next prev parent reply other threads:[~2022-11-15 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166850936462.27011.17289179422833914249@vcs2.savannah.gnu.org>
[not found] ` <20221115104926.4D491C0E4C8@vcs2.savannah.gnu.org>
2022-11-15 11:52 ` feature/tree-sitter 06db8015ea 1/5: Extract out treesit_make_ranges Po Lu
[not found] ` <20221115104926.5143AC0E4CA@vcs2.savannah.gnu.org>
2022-11-15 11:54 ` feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes Po Lu
2022-11-15 17:25 ` Yuan Fu [this message]
2022-11-15 18:06 ` Eli Zaretskii
2022-11-15 18:06 ` Visuwesh
2022-11-15 18:20 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AFD32557-2453-45A9-9E32-A4E960916869@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).