From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: feature/tree-sitter 34e50dc4a2 2/5: Allow tree-sitter to notify parse-tree changes Date: Tue, 15 Nov 2022 09:25:27 -0800 Message-ID: References: <166850936462.27011.17289179422833914249@vcs2.savannah.gnu.org> <20221115104926.5143AC0E4CA@vcs2.savannah.gnu.org> <877czwh1q4.fsf@yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12078"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 18:26:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouzhv-0002n3-F6 for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 18:26:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouzgx-0000qo-5R; Tue, 15 Nov 2022 12:25:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouzgj-0000p5-W1 for emacs-devel@gnu.org; Tue, 15 Nov 2022 12:25:42 -0500 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouzgh-0001h9-Db for emacs-devel@gnu.org; Tue, 15 Nov 2022 12:25:33 -0500 Original-Received: by mail-pj1-x1032.google.com with SMTP id h14so13909001pjv.4 for ; Tue, 15 Nov 2022 09:25:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iq22asUSR9TA5xS6UitK7r0JGrm/S+/Hcxud1IUcjuQ=; b=WrXLpTvzuZo2Ar8PXE1I8BeqRwSCYi48OdQ6HKT5+K24xTyHzgW8isU9HfU5LS3gJE BRcuPl0VH/B9Y7JqcbDg+77AiQYdB/jLs3Cdk76ux9BGdYFSHlaZtRpAmdWbKp054uOP pKBH2Cu1sV4Yp7382mETFSIDwS9wmqxQLuEfztBTI3PpDiShx0qnS9C8WgdLthjjbi1A 9Q06ona7waZdE8xnYpDMF5st+jD2Il/DZQbQp8bu2SV56AmMhGVjNH5JwdeG+GN4ubAD at6zPanwiPAqatIbngca8ittTL2v01ZZIBhxOFmjUk6KqKrN7AV1cAJORstlSuZwGVcq vWAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iq22asUSR9TA5xS6UitK7r0JGrm/S+/Hcxud1IUcjuQ=; b=WKqePvmjuzCw2nGPCeTyYwIALyohrlKiFhyhE0iUd/gDeMfdP+hhWGkMJyjSaOzbST puNC6mnvYAE4BFBKLkiJu/2DQTSq/Qfmswp9u/MzxOeZd4h051TVIoKIA9E+HQk8zW0V OctQuilbVfSHHRFX4ZJNokuC1oZelxs34De5HLOhGelGxnNaSk0A1OlJVKYesVYzSDI9 T5koAMZ0E8dM9BVBuKzvDPsDQ4BVP9zSLo4mxR+3SOeyMV7iF5tenar2ON2bEVuOs1Cs axDtg9mCiYJsEGLgR1aPWMHuI3nabAVtRYS0tE3vQxsvBKc/3Z332wm3HGMEJ1BPrqkM q8YQ== X-Gm-Message-State: ANoB5pkkpJ3oznbLUtRyUIO5SzDuy4oasqtXI9m+8iKGS20p8PomCqfk toLZD0xp4c0efwjTHASlr3E= X-Google-Smtp-Source: AA0mqf7NOK8unWhTkz9Uo/BnDFWLSVdpVTaRtN3cSYPGiXG+JwxSjRvI3nXQxsJ/u1h8sOtimHdltQ== X-Received: by 2002:a17:902:7104:b0:186:a8c1:884f with SMTP id a4-20020a170902710400b00186a8c1884fmr5203917pll.25.1668533129610; Tue, 15 Nov 2022 09:25:29 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id m3-20020a170902db0300b00176acd80f69sm10256832plx.102.2022.11.15.09.25.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Nov 2022 09:25:28 -0800 (PST) In-Reply-To: <877czwh1q4.fsf@yahoo.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=casouri@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299860 Archived-At: > On Nov 15, 2022, at 3:54 AM, Po Lu wrote: >=20 > Yuan Fu writes: >=20 >> +static Lisp_Object >> +treesit_make_ranges (const TSRange *, uint32_t, struct buffer *); >=20 > This should be: >=20 > static Lisp_Object treesit_make_ranges (const TSRange *, uint32_t, > struct buffer *); >=20 >> + Lisp_Object lisp_ranges =3D treesit_make_ranges(ranges, len, buf); >=20 > There is a missing space between "treesit_make_ranges" and its > parameters. >=20 >> + FOR_EACH_TAIL (functions) >> + safe_call2(XCAR (functions), lisp_ranges, parser); >=20 > Here too, between safe_call2 and the parameters. >=20 >> + treesit_call_after_change_functions(tree, new_tree, parser); >=20 > And here. >=20 >> +DEFUN ("treesit-parser-notifiers", >> + Ftreesit_parser_notifiers, >> + Streesit_parser_notifiers, >=20 >> + >> +DEFUN ("treesit-parser-add-notifier", >> + Ftreesit_parser_add_notifier, >> + Streesit_parser_add_notifier, >=20 >> + >> +DEFUN ("treesit-parser-remove-notifier", >> + Ftreesit_parser_remove_notifier, >> + Streesit_parser_remove_notifier, >=20 > Can't you put all of these on one line? All fixed! Thanks. BTW how do you send an email like this, with the tile = being the commit message and everything? Yuan=