From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Any exceptions for the 15-line rule?
Date: Wed, 01 May 2013 09:13:51 +0400 [thread overview]
Message-ID: <8761z31dv4.fsf@yandex.ru> (raw)
In-Reply-To: <517BD66C.8030906@yandex.ru> (Dmitry Gutov's message of "Sat, 27 Apr 2013 17:45:16 +0400")
Here's another case, with even more trivial code that for the most part
just changes a few constants to update them for spec changes.
https://github.com/mooz/js2-mode/pull/101
https://github.com/mooz/js2-mode/pull/100
(add .diff at the end of each URL to see the plain diff)
Unfortunately, I accidentally complicated #101 by also suggesting a
trivial code transformation: extracting one statement into a function,
which the reporter has promptly performed.
On the face of it, both patches exceed 15 lines in total, but I hesitate
to ask for CA over something this simple (this would also mean delaying
the next merge from Git to elpa for however long that takes).
Any suggestions?
next prev parent reply other threads:[~2013-05-01 5:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 3:20 Any exceptions for the 15-line rule? Dmitry Gutov
2013-04-27 4:41 ` Stefan Monnier
2013-04-27 12:26 ` Dmitry Gutov
2013-04-27 13:28 ` Stefan Monnier
2013-04-27 13:45 ` Dmitry Gutov
2013-05-01 5:13 ` Dmitry Gutov [this message]
2013-05-01 16:00 ` Glenn Morris
2013-05-01 17:50 ` Dmitry Gutov
2013-05-01 18:06 ` Glenn Morris
2013-05-01 20:37 ` Dmitry Gutov
2013-05-02 17:28 ` Glenn Morris
2013-05-04 5:27 ` Dmitry Gutov
2013-05-05 5:02 ` Stefan Monnier
2013-05-05 7:31 ` Dmitry Gutov
2013-05-06 1:05 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2013-05-01 12:33 Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761z31dv4.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).