From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Any exceptions for the 15-line rule? Date: Wed, 01 May 2013 09:13:51 +0400 Message-ID: <8761z31dv4.fsf@yandex.ru> References: <87d2tgu0ad.fsf@yandex.ru> <871u9wyxaz.fsf@yandex.ru> <517BD66C.8030906@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367385255 29739 80.91.229.3 (1 May 2013 05:14:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 1 May 2013 05:14:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 07:14:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UXPMs-0006Si-C2 for ged-emacs-devel@m.gmane.org; Wed, 01 May 2013 07:14:14 +0200 Original-Received: from localhost ([::1]:45860 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXPMr-0006Hd-OF for ged-emacs-devel@m.gmane.org; Wed, 01 May 2013 01:14:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXPMj-0006GO-Ow for emacs-devel@gnu.org; Wed, 01 May 2013 01:14:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXPMf-0006SP-GV for emacs-devel@gnu.org; Wed, 01 May 2013 01:14:05 -0400 Original-Received: from mail-lb0-f178.google.com ([209.85.217.178]:45373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXPMf-0006SF-92 for emacs-devel@gnu.org; Wed, 01 May 2013 01:14:01 -0400 Original-Received: by mail-lb0-f178.google.com with SMTP id w10so1175072lbi.23 for ; Tue, 30 Apr 2013 22:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type:x-antivirus :x-antivirus-status; bh=e2o4opnHykmc7faOsh63e61RqL3NQxiUBhhDuzhoknc=; b=enz3joz1TEOY78l8+dFOEHK5WmVaH4+MJ/DycJVmBOLnaZu/WmuW+guz05J6U4oQCz QZ764iQ/kWFeNzjOVnTLpNCcdLvjWNMm/OKXk8pju+uIbA6qV0DFIKjBAYgBb3ELRzxo Ct/uHmGR0rGnEHwJaM77D5IjVykfIs1eCjv/EQUE4HfO95tdKW9Q1sPRENjv16d0ryIk aefFK1MKPXvK/kXc3MQRW/9Ez1cPatK9y/+7sj8dif/jrLz0xqv2+1nxqSpg+TFW5ZHf TNkj+EYcpQH/79C/Ni7vNNwbynRqhirrwMKM51goKsGYF11xxlUvn+CqFuwsXUMGkRcI K15Q== X-Received: by 10.112.128.231 with SMTP id nr7mr675155lbb.26.1367385239971; Tue, 30 Apr 2013 22:13:59 -0700 (PDT) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPSA id u6sm620628lbe.4.2013.04.30.22.13.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 30 Apr 2013 22:13:58 -0700 (PDT) In-Reply-To: <517BD66C.8030906@yandex.ru> (Dmitry Gutov's message of "Sat, 27 Apr 2013 17:45:16 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Antivirus: avast! (VPS 130430-1, 01.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.217.178 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159231 Archived-At: Here's another case, with even more trivial code that for the most part just changes a few constants to update them for spec changes. https://github.com/mooz/js2-mode/pull/101 https://github.com/mooz/js2-mode/pull/100 (add .diff at the end of each URL to see the plain diff) Unfortunately, I accidentally complicated #101 by also suggesting a trivial code transformation: extracting one statement into a function, which the reporter has promptly performed. On the face of it, both patches exceed 15 lines in total, but I hesitate to ask for CA over something this simple (this would also mean delaying the next merge from Git to elpa for however long that takes). Any suggestions?