From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Any exceptions for the 15-line rule?
Date: Sat, 27 Apr 2013 17:45:16 +0400 [thread overview]
Message-ID: <517BD66C.8030906@yandex.ru> (raw)
In-Reply-To: <jwvzjwkt8hx.fsf-monnier+emacs@gnu.org>
On 27.04.2013 17:28, Stefan Monnier wrote:
>> Thanks, `substring' is better than `replace-match' I mentioned. But
>> still, should this be considered a full new implementation? Does
>> replacing `cond' with `if' in the inner condition make it a new piece of
>> code, as opposed to derivative one?
>
> The purpose is just to "simplify" the code, rather than to obscure
> the copyright. In terms of copyright, it does reduce the amount of code
> taken, indeed, but it's not a very significant difference.
I see.
>>> With such cleanups, the patch seems acceptable as a "tiny change".
>>> But please do ask for the CA as well (so the use of "tiny change" is
>>> mostly a way to avoid having to wait for the CA to go through).
>> To be clear, who do I ask to sign the CA over the modified patch? The
>> auto-complete-clang author, or the person who looked at a few pieces
>> from that package and adapted them to (admittedly, fairly similar)
>> company-clang code?
>
> In terms of who owns the copyright, the answer is probably "both", but
> to the extent that it fits the "tiny change" criteria we don't need to
> care too much (unless one or both of the authors already have
> contributed code as a "tiny change" since those things are cumulative).
> Assuming that we want company-mode and auto-complete to share more code
> in the future, having the assignment of AC's author is a good idea.
auto-complete-clang is a separate package from auto-complete (which has
multiple authors, but the principal one already has CA on file: Tomohiro
Matsuyama). I'll ask, although I think the only useful piece left we
could borrow is converting the lightweight markup in completion
candidates into syntax highlighting, and that I should be able to write
in some different way without much difficulty.
> As for the person who sent you the patch, it would also make sense to
> get his/her assignment if there's a chance he'll contribute more in
> the future.
Ok, I'll ask.
> PS: By the way, I think company-backends should be merged with (and/or
> moved over to) completion-at-point-functions, and some of those backends
> should be moved to their respective major modes.
Yes, I remember the email that accompanied your company-capf patch, but
so far I don't see a good way to go about it.
The interface provided by company-backends is considerably richer. How
do we fit that inside completion-at-point-functions?
There's also the problem of keeping compatibility with already released
Emacs versions. If we move the code, they won't be able to use it; if we
keep it, it would create duplication.
next prev parent reply other threads:[~2013-04-27 13:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 3:20 Any exceptions for the 15-line rule? Dmitry Gutov
2013-04-27 4:41 ` Stefan Monnier
2013-04-27 12:26 ` Dmitry Gutov
2013-04-27 13:28 ` Stefan Monnier
2013-04-27 13:45 ` Dmitry Gutov [this message]
2013-05-01 5:13 ` Dmitry Gutov
2013-05-01 16:00 ` Glenn Morris
2013-05-01 17:50 ` Dmitry Gutov
2013-05-01 18:06 ` Glenn Morris
2013-05-01 20:37 ` Dmitry Gutov
2013-05-02 17:28 ` Glenn Morris
2013-05-04 5:27 ` Dmitry Gutov
2013-05-05 5:02 ` Stefan Monnier
2013-05-05 7:31 ` Dmitry Gutov
2013-05-06 1:05 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2013-05-01 12:33 Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517BD66C.8030906@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).