unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org
Subject: Any exceptions for the 15-line rule?
Date: Sat, 27 Apr 2013 07:20:42 +0400	[thread overview]
Message-ID: <87d2tgu0ad.fsf@yandex.ru> (raw)

I've received a pull request [0] today for company-mode's Clang backend
that's essentially a request to borrow some (fairly simple) code from
the auto-complete-clang project [1].

The latter is licensed under GPLv3+, but I'm pretty sure the author
(brianjcj AT gmail, not sure what's his full name) has not signed the
CA. And I'm not wild about the idea of waiting several months to add the
feature (that is, if the author even agrees to sign the CA).

The change itself is almost entirely dictated by the interface provided
by the clang program, so while I can tweak a thing here and there to try
to create an independent implementation, it's not like solving a complex
problem, which you can approach from different directions.

For example, the definition of `company-clang--lang-option' the patch
[2] adds is more or less what takes it over the 15 lines limit. I said
I'll try to rewrite it, but should I bother?

It's basically a set of information about what values the "-x" option
takes, and while I can replace the main `cond' with the less efficient
`replace-string', the result will still resemble the original very
strongly.

Speaking of one of the stated reasons behind the CA, this is not the
kind of code I'd ever expect FSF to go to court over.

--Dmitry

[0] https://github.com/company-mode/company-mode/pull/17
[1] https://github.com/brianjcj/auto-complete-clang
[2] https://github.com/company-mode/company-mode/pull/17.diff




             reply	other threads:[~2013-04-27  3:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-27  3:20 Dmitry Gutov [this message]
2013-04-27  4:41 ` Any exceptions for the 15-line rule? Stefan Monnier
2013-04-27 12:26   ` Dmitry Gutov
2013-04-27 13:28     ` Stefan Monnier
2013-04-27 13:45       ` Dmitry Gutov
2013-05-01  5:13         ` Dmitry Gutov
2013-05-01 16:00           ` Glenn Morris
2013-05-01 17:50             ` Dmitry Gutov
2013-05-01 18:06               ` Glenn Morris
2013-05-01 20:37                 ` Dmitry Gutov
2013-05-02 17:28                   ` Glenn Morris
2013-05-04  5:27   ` Dmitry Gutov
2013-05-05  5:02     ` Stefan Monnier
2013-05-05  7:31       ` Dmitry Gutov
2013-05-06  1:05         ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2013-05-01 12:33 Barry OReilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2tgu0ad.fsf@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).