* Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail
[not found] ` <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org>
@ 2021-08-12 9:34 ` Robert Pluim
2021-08-12 12:49 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2021-08-12 9:34 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
>>>>> On Fri, 23 Jul 2021 14:18:34 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said:
Lars> (defun message-multi-smtp-send-mail ()
Lars> "Send the current buffer to `message-send-mail-function'.
Lars> @@ -4937,7 +4938,8 @@ that instead."
Lars> (message-send-mail-with-sendmail))
Lars> ((equal (car method) "smtp")
Lars> (require 'smtpmail)
Lars> - (let* ((smtpmail-smtp-server (nth 1 method))
Lars> + (let* ((smtpmail-store-queue-variables t)
Lars> + (smtpmail-smtp-server (nth 1 method))
Lars> (service (nth 2 method))
Lars> (port (string-to-number service))
Lars> ;; If we're talking to the TLS SMTP port, then force a
Why is smtpmail-store-queue-variables unconditionally bound to t here?
The user might be queuing mail, but not want to store the variables, no?
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail
2021-08-12 9:34 ` master 1f24519 1/2: Allow storing SMTP variables when queueing mail Robert Pluim
@ 2021-08-12 12:49 ` Lars Ingebrigtsen
2021-08-12 18:55 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-08-12 12:49 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
> Lars> - (let* ((smtpmail-smtp-server (nth 1 method))
> Lars> + (let* ((smtpmail-store-queue-variables t)
> Lars> + (smtpmail-smtp-server (nth 1 method))
> Lars> (service (nth 2 method))
> Lars> (port (string-to-number service))
> Lars> ;; If we're talking to the TLS SMTP port, then force a
>
> Why is smtpmail-store-queue-variables unconditionally bound to t here?
> The user might be queuing mail, but not want to store the variables, no?
In this case, the data is from the X-Message-SMTP-Method header. If the
user has used such a header, and is queuing the mail, then the user does
want to store the variables.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail
2021-08-12 12:49 ` Lars Ingebrigtsen
@ 2021-08-12 18:55 ` Robert Pluim
0 siblings, 0 replies; 3+ messages in thread
From: Robert Pluim @ 2021-08-12 18:55 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
>>>>> On Thu, 12 Aug 2021 14:49:49 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
Lars> - (let* ((smtpmail-smtp-server (nth 1 method))
Lars> + (let* ((smtpmail-store-queue-variables t)
Lars> + (smtpmail-smtp-server (nth 1 method))
Lars> (service (nth 2 method))
Lars> (port (string-to-number service))
Lars> ;; If we're talking to the TLS SMTP port, then force a
>>
>> Why is smtpmail-store-queue-variables unconditionally bound to t here?
>> The user might be queuing mail, but not want to store the variables, no?
Lars> In this case, the data is from the X-Message-SMTP-Method header. If the
Lars> user has used such a header, and is queuing the mail, then the user does
Lars> want to store the variables.
Iʼd say 'probably', but Iʼll admit that the percentage of people who
donʼt want that is pretty small.
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-12 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210723181832.28668.12066@vcs0.savannah.gnu.org>
[not found] ` <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org>
2021-08-12 9:34 ` master 1f24519 1/2: Allow storing SMTP variables when queueing mail Robert Pluim
2021-08-12 12:49 ` Lars Ingebrigtsen
2021-08-12 18:55 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).