unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail
Date: Thu, 12 Aug 2021 11:34:21 +0200	[thread overview]
Message-ID: <87eeazqa5e.fsf@gmail.com> (raw)
In-Reply-To: <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org> (Lars Ingebrigtsen's message of "Fri, 23 Jul 2021 14:18:34 -0400 (EDT)")

>>>>> On Fri, 23 Jul 2021 14:18:34 -0400 (EDT), larsi@gnus.org (Lars Ingebrigtsen) said:
    Lars>  (defun message-multi-smtp-send-mail ()
    Lars>    "Send the current buffer to `message-send-mail-function'.
    Lars> @@ -4937,7 +4938,8 @@ that instead."
    Lars>  	(message-send-mail-with-sendmail))
    Lars>         ((equal (car method) "smtp")
    Lars>  	(require 'smtpmail)
    Lars> -	(let* ((smtpmail-smtp-server (nth 1 method))
    Lars> +	(let* ((smtpmail-store-queue-variables t)
    Lars> +               (smtpmail-smtp-server (nth 1 method))
    Lars>  	       (service (nth 2 method))
    Lars>  	       (port (string-to-number service))
    Lars>  	       ;; If we're talking to the TLS SMTP port, then force a

Why is smtpmail-store-queue-variables unconditionally bound to t here?
The user might be queuing mail, but not want to store the variables, no?

Robert
-- 



       reply	other threads:[~2021-08-12  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210723181832.28668.12066@vcs0.savannah.gnu.org>
     [not found] ` <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org>
2021-08-12  9:34   ` Robert Pluim [this message]
2021-08-12 12:49     ` master 1f24519 1/2: Allow storing SMTP variables when queueing mail Lars Ingebrigtsen
2021-08-12 18:55       ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeazqa5e.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).