From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 1f24519 1/2: Allow storing SMTP variables when queueing mail Date: Thu, 12 Aug 2021 14:49:49 +0200 Message-ID: <87h7fun7yq.fsf@gnus.org> References: <20210723181832.28668.12066@vcs0.savannah.gnu.org> <20210723181834.5AE4C20D0A@vcs0.savannah.gnu.org> <87eeazqa5e.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35284"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 12 14:51:11 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEAAw-0008xV-FN for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Aug 2021 14:51:10 +0200 Original-Received: from localhost ([::1]:59490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEAAu-00068G-R9 for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Aug 2021 08:51:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEA9l-00057r-T5 for emacs-devel@gnu.org; Thu, 12 Aug 2021 08:49:57 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:58378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEA9k-0008Jz-9R for emacs-devel@gnu.org; Thu, 12 Aug 2021 08:49:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=389mjI4ojoa6eu5svpxWZHKjrFk753m1bwaHmbeLcvk=; b=BggiiBBpJfoKFbe5dcUyfd6ams dSzMF8aw78G8mHNDAkH08iosIyS29K07y0iVnyiTWz4j82D+TXFW03o9g96XnxMdlcoa/gbpPGpfg gBDql3RPpQPP1vJAlTbnm+/OQSwOFxBno9Em5Iie5hWRogor+qG+85UvWN4aAuAUpbr8=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEA9d-0005p5-Nj; Thu, 12 Aug 2021 14:49:53 +0200 In-Reply-To: <87eeazqa5e.fsf@gmail.com> (Robert Pluim's message of "Thu, 12 Aug 2021 11:34:21 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272352 Archived-At: Robert Pluim writes: > Lars> - (let* ((smtpmail-smtp-server (nth 1 method)) > Lars> + (let* ((smtpmail-store-queue-variables t) > Lars> + (smtpmail-smtp-server (nth 1 method)) > Lars> (service (nth 2 method)) > Lars> (port (string-to-number service)) > Lars> ;; If we're talking to the TLS SMTP port, then force a > > Why is smtpmail-store-queue-variables unconditionally bound to t here? > The user might be queuing mail, but not want to store the variables, no? In this case, the data is from the X-Message-SMTP-Method header. If the user has used such a header, and is queuing the mail, then the user does want to store the variables. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no