From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: Proposed changes to gnus-dup.el Date: Wed, 03 Apr 2019 02:59:51 +0100 Message-ID: <871s2jkfvs.fsf@tcd.ie> References: <8736nbip4l.fsf@tcd.ie> <875zs6rfdx.fsf@tcd.ie> <87pnqehlc0.fsf@ericabrahamsen.net> <87o95yq06r.fsf@tcd.ie> <877ecd9tqq.fsf@tcd.ie> <87a7h797u0.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2754"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 03 04:00:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBVCA-0000bJ-Rb for ged-emacs-devel@m.gmane.org; Wed, 03 Apr 2019 04:00:07 +0200 Original-Received: from localhost ([127.0.0.1]:48888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBVC9-0003ga-UZ for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 22:00:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBVC1-0003fv-Ik for emacs-devel@gnu.org; Tue, 02 Apr 2019 21:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBVC0-0002Ik-Eu for emacs-devel@gnu.org; Tue, 02 Apr 2019 21:59:57 -0400 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:39848) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBVBz-0002HF-RL for emacs-devel@gnu.org; Tue, 02 Apr 2019 21:59:56 -0400 Original-Received: by mail-ed1-x532.google.com with SMTP id p20so13403841eds.6 for ; Tue, 02 Apr 2019 18:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=p/lzlyfbfe7+EDxjFe7f3LfjA+oGqNsMilHIAU9yOD0=; b=fxLg26cDSOT/eTutKqw7uXqHnMhGMwWT02gXkcoXp4WrcgOeLKv6NJ2pM1QwCQexwk 1J6MvVLrRzwwvkSwgg8LEP9BdeIHTf0EaVZitCS2WI2qk/I6XDYw+Gix99hkeSVSPobu MmsQ766E+myD5Vqmon9ErkN9M6rQQEB9NZBbsm2MzYHTLoX9u8VPk3SH8wlbtZ6Cgxqg lVl/CWPCCz1ejnELeE/XBYaxH0cmZVLWAxTC72H3DVTNWhPoK0+jM511ox/u9O9iDL1d QQ/6dZhvi8Tsq58g6alLmPGgVDXur3f08wfk7A+LPfv/mWoOsIBNF6s+hddCIqLpA7pF P1Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=p/lzlyfbfe7+EDxjFe7f3LfjA+oGqNsMilHIAU9yOD0=; b=mBr4e0n/erde6w5lHkCSKQ7ZIOs/AfxR/yZmqGXENQ+nKLrhWjbOwb/5uqxljHQQyI h+W1JAd1E98mfVX85GJJA8fu2y0x9ZRTPrWTspYeeUVhJW78vIxAo3GOdg2wt2i3BApx p8hnWpeVQpAvpT0eoa45x9iJ/eQXT6DhGmKy5wMdKCwf+xempvaZCQNrtrjO3atcSlkO 3AGRYTMn/RVPnfzJpT+bpcn4p1apX19iF3WM/fEIq6PG68TeFmTkOTdB3Bn+JgI5AJ6Q STdFYmTTRK3M/2Jcj4ZkgYz0D9U4U11SEWrEmFXF/D/UDPLE8wHGJAJfqS0lGzaTOlL0 WKIg== X-Gm-Message-State: APjAAAUGusqsosn5SSYDGYMmOa5ylYzQhHxpxSi4PgwJQkvmUU7pIo4i 1ywEFanwWt0zgslvFSR7wT2sHg== X-Google-Smtp-Source: APXvYqyMUyliCdrKpmBhTxN5P19UzjIVKZWXfER0wa++tU4q5Ezmf6ZAQe0AsBJuxl2M5D1ZX4G/gw== X-Received: by 2002:a50:f4ef:: with SMTP id v44mr13832847edm.193.1554256793672; Tue, 02 Apr 2019 18:59:53 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f786:805d:f4ab:1006]) by smtp.gmail.com with ESMTPSA id l42sm4565588eda.60.2019.04.02.18.59.52 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 02 Apr 2019 18:59:52 -0700 (PDT) In-Reply-To: <87a7h797u0.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 02 Apr 2019 18:49:11 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::532 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234909 Archived-At: Eric Abrahamsen writes: > "Basil L. Contovounesios" writes: > >> "Basil L. Contovounesios" writes: >> >>> Eric Abrahamsen writes: >>> >>>> On 03/25/19 18:13 PM, Basil L. Contovounesios wrote: >>>>> >>>>> I will wait a few more days for people to comment and push the >>>>> rest of the patch if there are no serious objections. >>>> >>>> If I end up backing out the hash-table changes, will this patch still >>>> apply correctly? >>> >>> The original patch I sent will conflict with the hunks where you added >>> docstrings to gnus-dup-{list,hashtb} and switched from obarray to >>> hash-table operations. >>> >>> It would be easy for me to resolve these minor conflicts, but if that's >>> going to get in your way of more pressing work, then I'll hold off. >>> (That's not to say I think you should revert the hash-table changes.) >> >> Eric, just to be clear: may I push these minor changes, or would you >> rather I held off? > > Oh, sorry -- I'd assumed you'd already pushed them! They're good to go > as far as I'm concerned: in for a penny, in for a pound. Thanks, pushed. [1: 2bd3e48404]: * lisp/gnus/gnus-dup.el: Use lexical-binding 2019-04-03 02:55:41 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2bd3e484041b2b7ea47c236b86f59610d971b609 -- Basil