* Re: master 2053e350f3: Enable `dont-follow' for inotify file notifications
[not found] ` <20220916152410.3626FC00872@vcs2.savannah.gnu.org>
@ 2022-09-16 15:52 ` Robert Pluim
2022-09-16 16:36 ` Michael Albinus
0 siblings, 1 reply; 2+ messages in thread
From: Robert Pluim @ 2022-09-16 15:52 UTC (permalink / raw)
To: emacs-devel; +Cc: Michael Albinus
>>>>> On Fri, 16 Sep 2022 11:24:09 -0400 (EDT), Michael Albinus <Michael.Albinus@gmx.de> said:
Michael> branch: master
Michael> commit 2053e350f3d39e312a6a4b18c05fe8abefc5ee95
Michael> Author: Michael Albinus <michael.albinus@gmx.de>
Michael> Commit: Michael Albinus <michael.albinus@gmx.de>
Michael> Enable `dont-follow' for inotify file notifications
Michael> * doc/lispref/os.texi (File Notifications): Symlinks aren't followed.
Michael> * lisp/filenotify.el (file-notify--add-watch-inotify):
Michael> Add `dont-follow' flag.
Michael> * lisp/net/tramp.el (tramp-handle-file-notify-rm-watch):
Michael> Suppress errors when reading process output.
Michael> * test/lisp/filenotify-tests.el (file-notify-test11-symlinks)
Michael> (file-notify-test11-symlinks-remote): New tests.
I think this is NEWS-worthy.
Robert
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 2053e350f3: Enable `dont-follow' for inotify file notifications
2022-09-16 15:52 ` master 2053e350f3: Enable `dont-follow' for inotify file notifications Robert Pluim
@ 2022-09-16 16:36 ` Michael Albinus
0 siblings, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2022-09-16 16:36 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
Hi Robert,
> Michael> Enable `dont-follow' for inotify file notifications
>
> Michael> * doc/lispref/os.texi (File Notifications): Symlinks aren't followed.
>
> Michael> * lisp/filenotify.el (file-notify--add-watch-inotify):
> Michael> Add `dont-follow' flag.
>
> Michael> * lisp/net/tramp.el (tramp-handle-file-notify-rm-watch):
> Michael> Suppress errors when reading process output.
>
> Michael> * test/lisp/filenotify-tests.el (file-notify-test11-symlinks)
> Michael> (file-notify-test11-symlinks-remote): New tests.
>
> I think this is NEWS-worthy.
Don't know. It has always been agreement that we don't follow
symlinks. We've documented it now, and fixed the implementation.
A NEWS entry is called when we do the second step: add `follow' to the
flags of `file-notify-add-watch', and implement it.
> Robert
Best regards, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-16 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166334184972.30129.5302055700338325086@vcs2.savannah.gnu.org>
[not found] ` <20220916152410.3626FC00872@vcs2.savannah.gnu.org>
2022-09-16 15:52 ` master 2053e350f3: Enable `dont-follow' for inotify file notifications Robert Pluim
2022-09-16 16:36 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).