From: Michael Albinus <michael.albinus@gmx.de>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 2053e350f3: Enable `dont-follow' for inotify file notifications
Date: Fri, 16 Sep 2022 18:36:47 +0200 [thread overview]
Message-ID: <871qsbz36o.fsf@gmx.de> (raw)
In-Reply-To: <87k063fhb3.fsf@gmail.com> (Robert Pluim's message of "Fri, 16 Sep 2022 17:52:00 +0200")
Robert Pluim <rpluim@gmail.com> writes:
Hi Robert,
> Michael> Enable `dont-follow' for inotify file notifications
>
> Michael> * doc/lispref/os.texi (File Notifications): Symlinks aren't followed.
>
> Michael> * lisp/filenotify.el (file-notify--add-watch-inotify):
> Michael> Add `dont-follow' flag.
>
> Michael> * lisp/net/tramp.el (tramp-handle-file-notify-rm-watch):
> Michael> Suppress errors when reading process output.
>
> Michael> * test/lisp/filenotify-tests.el (file-notify-test11-symlinks)
> Michael> (file-notify-test11-symlinks-remote): New tests.
>
> I think this is NEWS-worthy.
Don't know. It has always been agreement that we don't follow
symlinks. We've documented it now, and fixed the implementation.
A NEWS entry is called when we do the second step: add `follow' to the
flags of `file-notify-add-watch', and implement it.
> Robert
Best regards, Michael.
prev parent reply other threads:[~2022-09-16 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166334184972.30129.5302055700338325086@vcs2.savannah.gnu.org>
[not found] ` <20220916152410.3626FC00872@vcs2.savannah.gnu.org>
2022-09-16 15:52 ` master 2053e350f3: Enable `dont-follow' for inotify file notifications Robert Pluim
2022-09-16 16:36 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qsbz36o.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).