From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 2053e350f3: Enable `dont-follow' for inotify file notifications Date: Fri, 16 Sep 2022 18:36:47 +0200 Message-ID: <871qsbz36o.fsf@gmx.de> References: <166334184972.30129.5302055700338325086@vcs2.savannah.gnu.org> <20220916152410.3626FC00872@vcs2.savannah.gnu.org> <87k063fhb3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10120"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 16 18:38:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZEMP-0002Ui-FM for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 18:38:37 +0200 Original-Received: from localhost ([::1]:54826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZEMN-0005dr-VB for ged-emacs-devel@m.gmane-mx.org; Fri, 16 Sep 2022 12:38:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZEKm-0004uq-Gn for emacs-devel@gnu.org; Fri, 16 Sep 2022 12:36:56 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:46829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZEKh-0000kw-7o for emacs-devel@gnu.org; Fri, 16 Sep 2022 12:36:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663346209; bh=leYwP1uwQRAQB/A3uTQf+M3TYmef6dgkXKkHohoQUDw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=dI7VOiQwQBN74Y7MYJoL1+Ci5ceOlnA784wFxPFUYfX/JN0So8g6+KnExFxcW5o2F EBav+c60Czvtnrg44rZnh3pAmPRhphbYRQ1PqvF7jH3sove2Fg460X4G6lyUYogt/C tKmn5bKLY1iSMgStLiZvqqpVYVt/Vy8fpJPZoR6o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.151.147]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEFvp-1oPZHZ2zHZ-00ABQE; Fri, 16 Sep 2022 18:36:48 +0200 In-Reply-To: <87k063fhb3.fsf@gmail.com> (Robert Pluim's message of "Fri, 16 Sep 2022 17:52:00 +0200") X-Provags-ID: V03:K1:Te6VEXP+GO6JM/2XOTIc4FaCo1kkUUsnGfT3pfI90f+Trm4egSO tH/8m6mI1K3I1fhhRpISy5cb/BsmoD4cxYtN4sh6vlHGLcOwXfcgYi6vAzivNdspvDW8D5l pWhbnjylU6OvuFuaHj9w1Y3POGlZxxy84bcQ2f/30zCNjXBH26LhJYiwyfvKMSjwXSeFCQs eei2boqdrpbDW5e+F6OWw== X-UI-Out-Filterresults: notjunk:1;V03:K0:92ZMJ0Pr17I=:grvf5af5AdbQSPIvr/rcqn JUNW+sYvI3iw/NucWxLeTgKBE8CDDzKlziYjwBQovJLMRFa/YGvvOG/zKNdyzeWZ23vYblFXA fQ+D2UiiPMFVUNRhiNxGBTVZeAB0oWuV+RWDjTEBPRxZaKJr487mblwzD7WrLhT/1LVMIHHyP KUpvkRWGH6SZg3mrrnA5qG0HwF7hNW2SuW44qwafTq07rY8WYvVkWhq/N7DUFciym8WAZ6i01 4cTsZF4p8kT0xogAxuEvPlnwzc9LelFxb4TE24mZK3MZm6u/xte//kizu4f9JZODPygID12ah Xz4qRY2pe/qtKxECS9l+gawSY8iRjeACrpAOej/OBsEw5uxJXT4+JVg7AybUSBTBMOB0sJPAd Z1SKr2nvXWIJ1dbp2N1du4h4ggP5UVrx5G/0aKGNmWJfcS5YYGBPLTIm2plIH/eMgXGN+Qrll E/KgKvNI+Qz6/P80SpgaPtckJaKYaPjogtySTpzDD3zrHsKnx1lzKX4fut5gn4pp1hA1LDP9I bJwbovdlTYNMoGuHDrZN5iXivT/o1tzSo1ncifby6Kr+SjnhpXBfUnyCOo9pHxjrVlzmrREd8 iDPZa5w/v27ZPrPTSRDc6kaIwptLJB1FVc4NKWp/Za8NgmBt7+5tZsxOzHGWuCdXst1tUls0z ehH6Cn9GUf+0oONp05Je4gQKUbeDJP6jUmXH/unSSXyQDzene1mQNjs6Me5Hx3+soGHUYK6je Fq2mq3gCQJDXonig9oIuRMLXGxAjiAa16+SMGNJctPEpXsoyj3u0bPfMzL8V1ttAn5dj8YLN Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295483 Archived-At: Robert Pluim writes: Hi Robert, > Michael> Enable `dont-follow' for inotify file notifications > > Michael> * doc/lispref/os.texi (File Notifications): Symlinks ar= en't followed. > > Michael> * lisp/filenotify.el (file-notify--add-watch-inotify): > Michael> Add `dont-follow' flag. > > Michael> * lisp/net/tramp.el (tramp-handle-file-notify-rm-watch)= : > Michael> Suppress errors when reading process output. > > Michael> * test/lisp/filenotify-tests.el (file-notify-test11-sym= links) > Michael> (file-notify-test11-symlinks-remote): New tests. > > I think this is NEWS-worthy. Don't know. It has always been agreement that we don't follow symlinks. We've documented it now, and fixed the implementation. A NEWS entry is called when we do the second step: add `follow' to the flags of `file-notify-add-watch', and implement it. > Robert Best regards, Michael.