* Re: master 41bf865: Clean up and simplify image-type setup
[not found] ` <20190518014334.856FE209DE@vcs0.savannah.gnu.org>
@ 2019-05-18 13:12 ` Andy Moreton
2019-05-18 14:47 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Andy Moreton @ 2019-05-18 13:12 UTC (permalink / raw)
To: emacs-devel
On Fri 17 May 2019, Paul Eggert wrote:
> branch: master
> commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
> Clean up and simplify image-type setup
>
> This also fixes an unlikely hang involving a circular image
> description.
This appears to break image handling on Windows for image formats that
use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
file from dired results in:
Cannot display image: (Invalid image specification)
The image buffer should have an image spec in the `display' (and
possibly `intangible') text properties at (point-min), but this is
missing.
Images work properly for emacs built from the previous commit on master.
AndyM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: master 41bf865: Clean up and simplify image-type setup
2019-05-18 13:12 ` master 41bf865: Clean up and simplify image-type setup Andy Moreton
@ 2019-05-18 14:47 ` Eli Zaretskii
2019-05-18 15:16 ` Andy Moreton
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2019-05-18 14:47 UTC (permalink / raw)
To: Andy Moreton; +Cc: emacs-devel
> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sat, 18 May 2019 14:12:45 +0100
>
> On Fri 17 May 2019, Paul Eggert wrote:
>
> > branch: master
> > commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
> > Author: Paul Eggert <eggert@cs.ucla.edu>
> > Commit: Paul Eggert <eggert@cs.ucla.edu>
> >
> > Clean up and simplify image-type setup
> >
> > This also fixes an unlikely hang involving a circular image
> > description.
>
> This appears to break image handling on Windows for image formats that
> use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
> file from dired results in:
>
> Cannot display image: (Invalid image specification)
Thanks, should be fixed now.
> The image buffer should have an image spec in the `display' (and
> possibly `intangible') text properties at (point-min), but this is
> missing.
The problem was with the code which probed whether a given image type
was already loaded.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 41bf865: Clean up and simplify image-type setup
2019-05-18 14:47 ` Eli Zaretskii
@ 2019-05-18 15:16 ` Andy Moreton
0 siblings, 0 replies; 3+ messages in thread
From: Andy Moreton @ 2019-05-18 15:16 UTC (permalink / raw)
To: emacs-devel
On Sat 18 May 2019, Eli Zaretskii wrote:
>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Sat, 18 May 2019 14:12:45 +0100
>>
>> On Fri 17 May 2019, Paul Eggert wrote:
>>
>> > branch: master
>> > commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
>> > Author: Paul Eggert <eggert@cs.ucla.edu>
>> > Commit: Paul Eggert <eggert@cs.ucla.edu>
>> >
>> > Clean up and simplify image-type setup
>> >
>> > This also fixes an unlikely hang involving a circular image
>> > description.
>>
>> This appears to break image handling on Windows for image formats that
>> use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
>> file from dired results in:
>>
>> Cannot display image: (Invalid image specification)
>
> Thanks, should be fixed now.
Thanks Eli, confirmed fixed.
AndyM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-18 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190518014332.5107.73518@vcs0.savannah.gnu.org>
[not found] ` <20190518014334.856FE209DE@vcs0.savannah.gnu.org>
2019-05-18 13:12 ` master 41bf865: Clean up and simplify image-type setup Andy Moreton
2019-05-18 14:47 ` Eli Zaretskii
2019-05-18 15:16 ` Andy Moreton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).