unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 41bf865: Clean up and simplify image-type setup
Date: Sat, 18 May 2019 17:47:41 +0300	[thread overview]
Message-ID: <83zhnj95v6.fsf@gnu.org> (raw)
In-Reply-To: <86blzzc3ea.fsf@gmail.com> (message from Andy Moreton on Sat, 18 May 2019 14:12:45 +0100)

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sat, 18 May 2019 14:12:45 +0100
> 
> On Fri 17 May 2019, Paul Eggert wrote:
> 
> > branch: master
> > commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
> > Author: Paul Eggert <eggert@cs.ucla.edu>
> > Commit: Paul Eggert <eggert@cs.ucla.edu>
> >
> >     Clean up and simplify image-type setup
> >     
> >     This also fixes an unlikely hang involving a circular image
> >     description.
> 
> This appears to break image handling on Windows for image formats that
> use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
> file from dired results in:
> 
>     Cannot display image: (Invalid image specification)

Thanks, should be fixed now.

> The image buffer should have an image spec in the `display' (and
> possibly `intangible') text properties at (point-min), but this is
> missing.

The problem was with the code which probed whether a given image type
was already loaded.



  reply	other threads:[~2019-05-18 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190518014332.5107.73518@vcs0.savannah.gnu.org>
     [not found] ` <20190518014334.856FE209DE@vcs0.savannah.gnu.org>
2019-05-18 13:12   ` master 41bf865: Clean up and simplify image-type setup Andy Moreton
2019-05-18 14:47     ` Eli Zaretskii [this message]
2019-05-18 15:16       ` Andy Moreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhnj95v6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).