From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 41bf865: Clean up and simplify image-type setup
Date: Sat, 18 May 2019 17:47:41 +0300
Message-ID: <83zhnj95v6.fsf@gnu.org>
References: <20190518014332.5107.73518@vcs0.savannah.gnu.org>
	<20190518014334.856FE209DE@vcs0.savannah.gnu.org>
	<86blzzc3ea.fsf@gmail.com>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="79512"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Andy Moreton <andrewjmoreton@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 18 16:53:09 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hS0hx-000KX1-GY
	for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 16:53:09 +0200
Original-Received: from localhost ([127.0.0.1]:35065 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hS0hw-0000Wy-FW
	for ged-emacs-devel@m.gmane.org; Sat, 18 May 2019 10:53:08 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:57340)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hS0ga-0008T5-SG
	for emacs-devel@gnu.org; Sat, 18 May 2019 10:51:45 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47752)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hS0ck-0004pE-Cg; Sat, 18 May 2019 10:47:46 -0400
Original-Received: from [176.228.60.248] (port=1843 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hS0cj-0004Il-SP; Sat, 18 May 2019 10:47:46 -0400
In-reply-to: <86blzzc3ea.fsf@gmail.com> (message from Andy Moreton on Sat, 18
	May 2019 14:12:45 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:236727
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/236727>

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sat, 18 May 2019 14:12:45 +0100
> 
> On Fri 17 May 2019, Paul Eggert wrote:
> 
> > branch: master
> > commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
> > Author: Paul Eggert <eggert@cs.ucla.edu>
> > Commit: Paul Eggert <eggert@cs.ucla.edu>
> >
> >     Clean up and simplify image-type setup
> >     
> >     This also fixes an unlikely hang involving a circular image
> >     description.
> 
> This appears to break image handling on Windows for image formats that
> use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
> file from dired results in:
> 
>     Cannot display image: (Invalid image specification)

Thanks, should be fixed now.

> The image buffer should have an image spec in the `display' (and
> possibly `intangible') text properties at (point-min), but this is
> missing.

The problem was with the code which probed whether a given image type
was already loaded.