unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: juri@linkov.net, michael_heerdegen@web.de, emacs-devel@gnu.org,
	orontee@gmail.com
Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b'
Date: Wed, 26 Apr 2023 12:18:07 +0300	[thread overview]
Message-ID: <83zg6vt31s.fsf@gnu.org> (raw)
In-Reply-To: <878reft5vf.fsf@gmail.com> (message from Robert Pluim on Wed, 26 Apr 2023 10:17:08 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Juri Linkov <juri@linkov.net>,  michael_heerdegen@web.de,
>   emacs-devel@gnu.org,  orontee@gmail.com
> Date: Wed, 26 Apr 2023 10:17:08 +0200
> 
> >>>>> On Tue, 25 Apr 2023 21:00:08 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     >> >> So I see no reason to remove 'custom-function'.
>     >> >> What could be done instead is to add a new choice
>     >> >> 'custom-predicate'.
>     >> >
>     >> > The suggestion is not to remove custom-function.  The suggestion is to
>     >> > require that the function returns a boolean, to mean whether to hide
>     >> > or not to hide a heading, instead of requesting that the function
>     >> > itself hides/unhides the headings.
>     >> >
>     >> > What is the purpose of requesting a custom function to actually
>     >> > hide/unhide the headings, i.e. to know enough about the structure and
>     >> > internal details of Outline mode to do its job?
>     >> 
>     >> How the user would be able to use 'outline-show-branches'
>     >> in the custom function, and not to use 'outline-hide-entry'?
> 
>     Eli> Sorry, I don't understand the question and its relevance.  Maybe
>     Eli> Robert does.
> 
> In the current implementation, the user is free to write a function
> that uses any of the outline-show/hide functions to get the effect
> they desire. If we replace that with just a predicate function, then
> theyʼre effectively restricted to `outline-hide-entry' and
> `outline-show-subtree'.
> 
> I guess we could add `predicate', to be checked before
> `custom-function', if set. If we do that, we definitely need to
> document which outline functions are available. 100% backwards
> compatible as well 😄

Or maybe we stay with custom-function, but allow it to return symbols
other than nil and t, so it could, for example, return
'outline-show-branches'?



  reply	other threads:[~2023-04-26  9:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org>
     [not found] ` <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org>
2023-04-24 13:08   ` master 2ef6f943abd: Add option to control default outlining in 'C-h b' Robert Pluim
2023-04-24 16:24     ` Eli Zaretskii
2023-04-24 16:45       ` Robert Pluim
2023-04-24 18:34         ` Eli Zaretskii
2023-04-25  8:13           ` Robert Pluim
2023-04-25  1:13       ` Michael Heerdegen
2023-04-25  6:45         ` Eli Zaretskii
2023-04-25  8:25           ` Robert Pluim
2023-04-25  9:09             ` Eli Zaretskii
2023-04-25 10:11               ` Robert Pluim
2023-04-25 11:44                 ` Eli Zaretskii
2023-04-25 12:17                   ` Robert Pluim
2023-04-25 16:51                   ` Juri Linkov
2023-04-25 17:02                     ` Eli Zaretskii
2023-04-25 17:35                       ` Juri Linkov
2023-04-25 18:00                         ` Eli Zaretskii
2023-04-26  8:17                           ` Robert Pluim
2023-04-26  9:18                             ` Eli Zaretskii [this message]
2023-04-26 10:01                               ` Robert Pluim
2023-04-26 10:33                                 ` Eli Zaretskii
2023-04-26 11:52                                   ` Robert Pluim
2023-04-25 18:32                       ` Michael Heerdegen
2023-05-29 13:16                         ` Robert Pluim
2023-05-30  1:08                           ` Michael Heerdegen
2023-04-29  8:13     ` Eshel Yaron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zg6vt31s.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=michael_heerdegen@web.de \
    --cc=orontee@gmail.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).