unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com
Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b'
Date: Tue, 25 Apr 2023 12:09:58 +0300	[thread overview]
Message-ID: <838regwcnt.fsf@gnu.org> (raw)
In-Reply-To: <87leig9xm8.fsf@gmail.com> (message from Robert Pluim on Tue, 25 Apr 2023 10:25:51 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Michael Heerdegen <michael_heerdegen@web.de>,  emacs-devel@gnu.org,
>  Matthias Meulien <orontee@gmail.com>
> Date: Tue, 25 Apr 2023 10:25:51 +0200
> 
> >>>>> On Tue, 25 Apr 2023 09:45:36 +0300, Eli Zaretskii <eliz@gnu.org> said:
> 
>     Eli> Feel free to suggest a better tag, TIA.  Bonus points for untangling
>     Eli> the IMNSHO confusing documentation of outline-default-rules in these
>     Eli> areas (e.g., what does "function is expected to toggle the heading
>     Eli> visibility" even mean??) and fixing that and the related tags as well.
>     Eli> I simply had no time for that, sorry, and saying just "Custom
>     Eli> function" without any hint what that function should do seemed like a
>     Eli> bad idea.
> 
> The custom function is just funcallʼed, which is somewhat unfriendly,
> since it forces the user to understand the details of how to hide
> headings, which are not documented (what happens if the custom
> function does nothing?). A predicate function would be more useful.
> 
> This code and the defcustom is new in emacs-29, so we can still change
> it to be a predicate instead. At least we should document is better

Agreed.  Patches welcome.



  reply	other threads:[~2023-04-25  9:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org>
     [not found] ` <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org>
2023-04-24 13:08   ` master 2ef6f943abd: Add option to control default outlining in 'C-h b' Robert Pluim
2023-04-24 16:24     ` Eli Zaretskii
2023-04-24 16:45       ` Robert Pluim
2023-04-24 18:34         ` Eli Zaretskii
2023-04-25  8:13           ` Robert Pluim
2023-04-25  1:13       ` Michael Heerdegen
2023-04-25  6:45         ` Eli Zaretskii
2023-04-25  8:25           ` Robert Pluim
2023-04-25  9:09             ` Eli Zaretskii [this message]
2023-04-25 10:11               ` Robert Pluim
2023-04-25 11:44                 ` Eli Zaretskii
2023-04-25 12:17                   ` Robert Pluim
2023-04-25 16:51                   ` Juri Linkov
2023-04-25 17:02                     ` Eli Zaretskii
2023-04-25 17:35                       ` Juri Linkov
2023-04-25 18:00                         ` Eli Zaretskii
2023-04-26  8:17                           ` Robert Pluim
2023-04-26  9:18                             ` Eli Zaretskii
2023-04-26 10:01                               ` Robert Pluim
2023-04-26 10:33                                 ` Eli Zaretskii
2023-04-26 11:52                                   ` Robert Pluim
2023-04-25 18:32                       ` Michael Heerdegen
2023-05-29 13:16                         ` Robert Pluim
2023-05-30  1:08                           ` Michael Heerdegen
2023-04-29  8:13     ` Eshel Yaron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=838regwcnt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=orontee@gmail.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).