From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2ef6f943abd: Add option to control default outlining in 'C-h b' Date: Wed, 26 Apr 2023 12:18:07 +0300 Message-ID: <83zg6vt31s.fsf@gnu.org> References: <168233653969.13461.3810563138120581789@vcs2.savannah.gnu.org> <20230424114219.F2AEAC0004A@vcs2.savannah.gnu.org> <877cu1bf6q.fsf@gmail.com> <834jp5xn7v.fsf@gnu.org> <87a5ywn4qj.fsf@web.de> <83r0s8wjcf.fsf@gnu.org> <87leig9xm8.fsf@gmail.com> <838regwcnt.fsf@gnu.org> <87fs8o9spe.fsf@gmail.com> <835y9kw5ix.fsf@gnu.org> <86h6t3rjl8.fsf@mail.linkov.net> <83leifvqsz.fsf@gnu.org> <86wn1zoofr.fsf@mail.linkov.net> <83h6t3vo47.fsf@gnu.org> <878reft5vf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26535"; mail-complaints-to="usenet@ciao.gmane.io" Cc: juri@linkov.net, michael_heerdegen@web.de, emacs-devel@gnu.org, orontee@gmail.com To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 26 11:18:44 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prbIS-0006hm-An for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Apr 2023 11:18:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prbHe-0007qN-7D; Wed, 26 Apr 2023 05:17:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prbHd-0007pz-3t for emacs-devel@gnu.org; Wed, 26 Apr 2023 05:17:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prbHb-00053l-BS; Wed, 26 Apr 2023 05:17:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IAgPJs21dG60B/oNruPIw1orZwKBL+ibAAdHDCI5pwU=; b=eyMk4fBsqb8gvA/Irrx0 Nr9JOEPQr3IaMBb4+dIeMJee+9S22+Gl4S8YUG6cYXCz89ZoThnWACyFai/onj0Y00zdSATzhlKxQ nvCryFjoTuFqfjkRbFB9I62oIBJuC4pWppQoLmazUH364P2R/65fhyWtZh7Ov51RC+6Z1HifFxMVZ RuioecjdeAsCS0HuWgqO2laJCsNALMgjfkIqNNTs9TGiALY8lOgQ9yCmxx2EhcqGR82PjufthL7UU JoVzK5blu+YG/1mOSqRi/cpSD7TGfRp7Ogm+5r+nDosk6iWiBZS2+b4IZ3YWz28QnOe7R1GP8o67g Q6E7Lbv8G2G1Jw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prbHO-00023h-35; Wed, 26 Apr 2023 05:17:50 -0400 In-Reply-To: <878reft5vf.fsf@gmail.com> (message from Robert Pluim on Wed, 26 Apr 2023 10:17:08 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305678 Archived-At: > From: Robert Pluim > Cc: Juri Linkov , michael_heerdegen@web.de, > emacs-devel@gnu.org, orontee@gmail.com > Date: Wed, 26 Apr 2023 10:17:08 +0200 > > >>>>> On Tue, 25 Apr 2023 21:00:08 +0300, Eli Zaretskii said: > > >> >> So I see no reason to remove 'custom-function'. > >> >> What could be done instead is to add a new choice > >> >> 'custom-predicate'. > >> > > >> > The suggestion is not to remove custom-function. The suggestion is to > >> > require that the function returns a boolean, to mean whether to hide > >> > or not to hide a heading, instead of requesting that the function > >> > itself hides/unhides the headings. > >> > > >> > What is the purpose of requesting a custom function to actually > >> > hide/unhide the headings, i.e. to know enough about the structure and > >> > internal details of Outline mode to do its job? > >> > >> How the user would be able to use 'outline-show-branches' > >> in the custom function, and not to use 'outline-hide-entry'? > > Eli> Sorry, I don't understand the question and its relevance. Maybe > Eli> Robert does. > > In the current implementation, the user is free to write a function > that uses any of the outline-show/hide functions to get the effect > they desire. If we replace that with just a predicate function, then > theyʼre effectively restricted to `outline-hide-entry' and > `outline-show-subtree'. > > I guess we could add `predicate', to be checked before > `custom-function', if set. If we do that, we definitely need to > document which outline functions are available. 100% backwards > compatible as well 😄 Or maybe we stay with custom-function, but allow it to return symbols other than nil and t, so it could, for example, return 'outline-show-branches'?