From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: rpluim@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: server.el test failures
Date: Tue, 28 Feb 2023 21:23:02 +0200 [thread overview]
Message-ID: <83wn41fvc9.fsf@gnu.org> (raw)
In-Reply-To: <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> (message from Jim Porter on Tue, 28 Feb 2023 11:02:25 -0800)
> Date: Tue, 28 Feb 2023 11:02:25 -0800
> Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> > Eli> I don't think we should create GUI frames in batch, since the SIGIO
> > Eli> handler is not set, and we generally aren't prepared for receiving
> > Eli> it. We should create a TTY frame instead, or maybe no frame at all.
> >
> > I think the former would be better. Jim, since you wrote this test,
> > what do you think?
>
> We should definitely create a frame in these tests, since that's what
> the tests are trying to, well, test. (All the server tests are there to
> make sure that the usual things you might do with "emacsclient" work
> properly.)
>
> This might be a real bug in Emacs: as Eli says, an Emacs server started
> in batch mode shouldn't create GUI frames, but on the other hand, this
> might be only be relevant to the regression tests (who starts an Emacs
> server in a batch session?). I wouldn't mind just adding "-nw" to all
> the "emacsclient -c" invocations in server-tests.el.
How about changing make-frame on master to create a TTY frame in batch
sessions, even if DISPLAY is set in the environment?
next prev parent reply other threads:[~2023-02-28 19:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <877h40vb8h.fsf@mail.jurta.org>
[not found] ` <4EA4D31B.4050604@cs.ucla.edu>
[not found] ` <E1RISPO-0007Eu-TE@fencepost.gnu.org>
[not found] ` <4EA5E08D.8070903@cs.ucla.edu>
[not found] ` <861qmvcglp.fsf@aarsen.me>
[not found] ` <f711f43f-6892-f849-21ec-26376c351f11@cs.ucla.edu>
2023-02-13 21:55 ` server.el test failures (was: Re: bug#9800: Incomplete truncated file buffers from the /proc filesystem) Jim Porter
2023-02-14 2:47 ` Paul Eggert
2023-02-15 7:06 ` Jim Porter
2023-02-15 18:20 ` Paul Eggert
2023-02-23 23:42 ` Paul Eggert
2023-02-24 0:50 ` Jim Porter
2023-02-24 2:20 ` Jim Porter
2023-02-24 3:25 ` Po Lu
2023-02-24 3:38 ` Jim Porter
2023-02-24 7:52 ` Eli Zaretskii
2023-02-24 17:48 ` Jim Porter
2023-02-24 18:37 ` Eli Zaretskii
2023-02-24 19:45 ` Alan Mackenzie
2023-02-24 20:31 ` Jim Porter
2023-02-24 20:47 ` Eli Zaretskii
2023-02-26 8:29 ` Paul Eggert
2023-02-26 9:47 ` Eli Zaretskii
2023-02-27 5:31 ` Jim Porter
2023-02-27 16:40 ` server.el test failures Robert Pluim
2023-02-27 16:50 ` Eli Zaretskii
2023-02-27 18:14 ` Robert Pluim
2023-02-27 18:39 ` Eli Zaretskii
2023-02-28 7:42 ` Robert Pluim
2023-02-28 12:13 ` Eli Zaretskii
2023-02-28 13:05 ` Robert Pluim
2023-02-28 19:02 ` Jim Porter
2023-02-28 19:23 ` Eli Zaretskii [this message]
2023-02-28 19:41 ` Jim Porter
2023-03-01 8:22 ` Robert Pluim
2023-03-02 22:15 ` Jim Porter
2023-03-03 7:00 ` Eli Zaretskii
2023-03-03 7:15 ` Jim Porter
2023-03-03 8:00 ` Jim Porter
2023-03-03 8:10 ` Eli Zaretskii
2023-03-03 17:27 ` Jim Porter
2023-03-03 8:16 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wn41fvc9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).