From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
Subject: Re: server.el test failures (was: Re: bug#9800: Incomplete truncated file buffers from the /proc filesystem)
Date: Fri, 24 Feb 2023 20:37:25 +0200 [thread overview]
Message-ID: <83mt52nc4a.fsf@gnu.org> (raw)
In-Reply-To: <b486497d-c9b6-3875-f832-3047ab39581d@gmail.com> (message from Jim Porter on Fri, 24 Feb 2023 09:48:02 -0800)
> Date: Fri, 24 Feb 2023 09:48:02 -0800
> Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 2/23/2023 11:52 PM, Eli Zaretskii wrote:
> >> Date: Thu, 23 Feb 2023 18:20:39 -0800
> >> From: Jim Porter <jporterbugs@gmail.com>
> >> Cc: emacs-devel@gnu.org
> >>
> >> The segfault is in FACE_FROM_ID_OR_NULL, called from
> >> Finternal_merge_in_global_face. It happens because the face_cache is
> >> null during these tests (since Emacs is noninteractive).
> >>
> >> The attached patch fixes the issue for me, though I'm not totally sure
> >> it's the *right* fix. Any thoughts? (I'm also not 100% sure this is the
> >> same issue you're seeing...)
> >
> > Please show the C backtrace from the crash, and include the Lisp
> > backtrace (the "xbacktrace" command in src/.gdbinit).
>
> Ok, I ran Emacs (master branch) under GDB with the following arguments:
>
> -Q -L ":../test" -l ert -l lisp/server-tests.el --batch --eval
> '(ert-run-tests-batch-and-exit (quote (not (or (tag :unstable) (tag
> :nativecomp)))))'
>
> Attached is the backtrace from 'xbacktrace'.
>
> I think this only occurs when starting the Emacs server in a batch-mode
> Emacs process and then starting a client via "emacsclient -c". I see the
> segfault when running any of the tests in test/lisp/server-tests.el that
> create a frame (e.g. 'server-tests/server-start/stop-prompt-with-client').
>
> This also only seems to occur if the first face that
> 'face-set-after-frame-default' passes to 'internal-merge-in-global-face'
> is the default face.
Thanks. Does the patch below give good results?
diff --git a/src/xfaces.c b/src/xfaces.c
index 62d7823..37b7039 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -4186,7 +4186,9 @@ DEFUN ("internal-merge-in-global-face", Finternal_merge_in_global_face,
if (EQ (face, Qdefault))
{
struct face_cache *c = FRAME_FACE_CACHE (f);
- struct face *newface, *oldface = FACE_FROM_ID_OR_NULL (f, DEFAULT_FACE_ID);
+ struct face *newface;
+ struct face *oldface =
+ c ? FACE_FROM_ID_OR_NULL (f, DEFAULT_FACE_ID) : NULL;
Lisp_Object attrs[LFACE_VECTOR_SIZE];
/* This can be NULL (e.g., in batch mode). */
next prev parent reply other threads:[~2023-02-24 18:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <877h40vb8h.fsf@mail.jurta.org>
[not found] ` <4EA4D31B.4050604@cs.ucla.edu>
[not found] ` <E1RISPO-0007Eu-TE@fencepost.gnu.org>
[not found] ` <4EA5E08D.8070903@cs.ucla.edu>
[not found] ` <861qmvcglp.fsf@aarsen.me>
[not found] ` <f711f43f-6892-f849-21ec-26376c351f11@cs.ucla.edu>
2023-02-13 21:55 ` server.el test failures (was: Re: bug#9800: Incomplete truncated file buffers from the /proc filesystem) Jim Porter
2023-02-14 2:47 ` Paul Eggert
2023-02-15 7:06 ` Jim Porter
2023-02-15 18:20 ` Paul Eggert
2023-02-23 23:42 ` Paul Eggert
2023-02-24 0:50 ` Jim Porter
2023-02-24 2:20 ` Jim Porter
2023-02-24 3:25 ` Po Lu
2023-02-24 3:38 ` Jim Porter
2023-02-24 7:52 ` Eli Zaretskii
2023-02-24 17:48 ` Jim Porter
2023-02-24 18:37 ` Eli Zaretskii [this message]
2023-02-24 19:45 ` Alan Mackenzie
2023-02-24 20:31 ` Jim Porter
2023-02-24 20:47 ` Eli Zaretskii
2023-02-26 8:29 ` Paul Eggert
2023-02-26 9:47 ` Eli Zaretskii
2023-02-27 5:31 ` Jim Porter
2023-02-27 16:40 ` server.el test failures Robert Pluim
2023-02-27 16:50 ` Eli Zaretskii
2023-02-27 18:14 ` Robert Pluim
2023-02-27 18:39 ` Eli Zaretskii
2023-02-28 7:42 ` Robert Pluim
2023-02-28 12:13 ` Eli Zaretskii
2023-02-28 13:05 ` Robert Pluim
2023-02-28 19:02 ` Jim Porter
2023-02-28 19:23 ` Eli Zaretskii
2023-02-28 19:41 ` Jim Porter
2023-03-01 8:22 ` Robert Pluim
2023-03-02 22:15 ` Jim Porter
2023-03-03 7:00 ` Eli Zaretskii
2023-03-03 7:15 ` Jim Porter
2023-03-03 8:00 ` Jim Porter
2023-03-03 8:10 ` Eli Zaretskii
2023-03-03 17:27 ` Jim Porter
2023-03-03 8:16 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt52nc4a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).