From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: server.el test failures Date: Tue, 28 Feb 2023 21:23:02 +0200 Message-ID: <83wn41fvc9.fsf@gnu.org> References: <877h40vb8h.fsf@mail.jurta.org> <4EA4D31B.4050604@cs.ucla.edu> <4EA5E08D.8070903@cs.ucla.edu> <861qmvcglp.fsf@aarsen.me> <98e880a0-d076-cfd9-b39d-50c84fa8975a@gmail.com> <811d85e0-4032-68df-bc0c-1073ff5d1b96@cs.ucla.edu> <5a38c18d-263c-223b-7335-8395a10eb494@gmail.com> <00864fe6-b63a-685f-2d20-4e1fd5a5573e@cs.ucla.edu> <3e7c26d6-215a-6c29-5304-0e32f42b2174@gmail.com> <87zg8z5afj.fsf@gmail.com> <83ttz7giib.fsf@gnu.org> <87r0ub561t.fsf@gmail.com> <83sfergdgf.fsf@gnu.org> <87h6v6qlq7.fsf@gmail.com> <83ilfmgf88.fsf@gnu.org> <87cz5uq6s1.fsf@gmail.com> <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19728"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 28 20:23:34 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pX5ZW-0004x9-1G for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Feb 2023 20:23:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pX5Yt-0000bd-Tm; Tue, 28 Feb 2023 14:22:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX5Yr-0000ZX-Ge for emacs-devel@gnu.org; Tue, 28 Feb 2023 14:22:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX5Yq-0006OF-J4; Tue, 28 Feb 2023 14:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z/iHt9+mEgO6mM9gLbchYj0dGBIHLtpPPA/PkaXC/pE=; b=DVygxNX+ak/B dzT+57V0jhyTzy3q9BNK86G34KJlWC/+FbhzheKkUHpGDVy4wLAxz0U8CW2niZGML05jn77tewAQN 2+OPyoXyLot51fK5cRTZhD2sgzG2x5efsXGG2dY6d/0LMIG3SzhU3xKh+08mkhT1VniuZFaOmI4ql qcuo5iQbij0KjVUAs3XCmB50+HREokv6YHzF96vNu1qnsC7kkDbF0N7FXZPMdY69aYQ70TpIRLpxj n/T+k45shbtneBtLGq3Nl42Ky6UoSKfq1U0vGa8FQr0dOe/wtCAFhZgVY0UYomjx2oHr+q9O5AFVH gFkEE7PJNPepI18P32dhkQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX5Yp-0004aC-TK; Tue, 28 Feb 2023 14:22:52 -0500 In-Reply-To: <84c54b68-e787-2bc5-0908-52d953b557d2@gmail.com> (message from Jim Porter on Tue, 28 Feb 2023 11:02:25 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303866 Archived-At: > Date: Tue, 28 Feb 2023 11:02:25 -0800 > Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org > From: Jim Porter > > > Eli> I don't think we should create GUI frames in batch, since the SIGIO > > Eli> handler is not set, and we generally aren't prepared for receiving > > Eli> it. We should create a TTY frame instead, or maybe no frame at all. > > > > I think the former would be better. Jim, since you wrote this test, > > what do you think? > > We should definitely create a frame in these tests, since that's what > the tests are trying to, well, test. (All the server tests are there to > make sure that the usual things you might do with "emacsclient" work > properly.) > > This might be a real bug in Emacs: as Eli says, an Emacs server started > in batch mode shouldn't create GUI frames, but on the other hand, this > might be only be relevant to the regression tests (who starts an Emacs > server in a batch session?). I wouldn't mind just adding "-nw" to all > the "emacsclient -c" invocations in server-tests.el. How about changing make-frame on master to create a TTY frame in batch sessions, even if DISPLAY is set in the environment?