Re: server.el test failures

[Jim Porter <jporterbugs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On 2/28/2023 11:23 AM, Eli Zaretskii wrote:
> How about changing make-frame on master to create a TTY frame in batch
> sessions, even if DISPLAY is set in the environment?

That could work. Just to see what would happen, I tried running the 
Emacs server in a batch session and then calling "emacsclient -c -nw":

   emacs -Q --batch --eval '(progn (server-start) (while t (sit-for 1)))'
   emacsclient -c -nw

Surprisingly, it seems to mostly work, although it echoes control 
characters to the screen.

Anyway, here's a patch for this. Maybe there's a better way to do it, 
but this seemed like the least-invasive.

[-- Attachment #2: 0001-Don-t-create-GUI-frames-in-batch-sessions.patch --]
[-- Type: text/plain, Size: 1258 bytes --]

From d399ca03c0d91da7ad2aa70e76284a13c49d453d Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Tue, 28 Feb 2023 11:35:21 -0800
Subject: [PATCH] Don't create GUI frames in batch sessions

This resolves an issue with running test/lisp/server-tests.el when
'DISPLAY' is set: the tests would start the Emacs server in a batch
session, and then request a new GUI frame.  However, that caused the
tests to terminate with SIGIO, since a batch Emacs doesn't set a SIGIO
handler.

Ref: <https://lists.gnu.org/archive/html/emacs-devel/2023-02/msg00879.html>

* lisp/frame.el (make-frame): Override the 'display' parameter in
batch sessions.
---
 lisp/frame.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/frame.el b/lisp/frame.el
index b820d5fcd96..03cbd26ca0a 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -871,6 +871,10 @@ make-frame
 frame the selected frame.  However, the window system may select
 the new frame according to its own rules."
   (interactive)
+  ;; When running in a batch session, we can't create a GUI frame.
+  (when noninteractive
+    (push '(display . nil) parameters))
+
   (let* ((display (cdr (assq 'display parameters)))
          (w (cond
              ((assq 'terminal parameters)
-- 
2.25.1