unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Mike Hamrick <mikeh@muppetlabs.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
Date: Tue, 11 Aug 2020 22:17:08 +0300	[thread overview]
Message-ID: <83v9hpngaz.fsf@gnu.org> (raw)
In-Reply-To: <m1lfk9fx6j.fsf@eidolon.muppetlabs.com> (message from Mike Hamrick on Fri, 26 Jun 2020 12:23:48 -0700)

> From: Mike Hamrick <mikeh@muppetlabs.com>
> Cc: emacs-devel@gnu.org
> Date: Fri, 26 Jun 2020 12:23:48 -0700
> 
> I've updated my patch to include a NEWS item.  I grepped through the
> manual looking for areas that might need updating, and did not find
> any.

Thanks, a couple of really minor nits below:

> @@ -1971,7 +1974,8 @@ turn_off_face (struct frame *f, int face_id)
>        if (face->tty_bold_p
>  	  || face->tty_italic_p
>  	  || face->tty_reverse_p
> -	  || face->tty_underline_p)
> +	  || face->tty_underline_p
> +          || face->tty_strike_through_p)

Please use our style of indentation in C source files (basically, make
sure indent-tabs-mode is non-nil).

Also, please make sure the patch still applies to the current master,
and if not, please update it.

Thanks.



  parent reply	other threads:[~2020-08-11 19:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 21:44 [PATCH] TTY Support for ECMA-48 strike-through graphic rendition Mike Hamrick
2020-06-26 10:46 ` Eli Zaretskii
2020-06-26 19:23   ` Mike Hamrick
2020-06-26 19:38     ` Eli Zaretskii
2020-08-11 19:17     ` Eli Zaretskii [this message]
2020-08-12  9:36       ` Robert Pluim
2020-08-12 14:23         ` Eli Zaretskii
2020-08-12 16:19           ` Robert Pluim
2020-08-12 18:12             ` Stefan Monnier
2020-09-13 23:05       ` Mike Hamrick
2020-09-14 22:25       ` Mike Hamrick
2020-09-18  8:55         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v9hpngaz.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mikeh@muppetlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).